All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Craig <philipc@snapgear.com>
To: "Sébastien LAVEZE" <slaveze@gmail.com>,
	"Pablo Neira Ayuso" <pablo@eurodev.net>
Cc: netfilter-devel@lists.netfilter.org
Subject: [PATCH] conntrack: Fix option parsing for ARM
Date: Fri, 12 May 2006 17:11:27 +1000	[thread overview]
Message-ID: <4464351F.6000402@snapgear.com> (raw)
In-Reply-To: <ca021ab30605100118u16675c7au933a464ebe64d705@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 340 bytes --]

On 05/10/2006 06:18 PM, Sébastien LAVEZE wrote:
> I have problem using the conntrack utility...
> It always display the help message and i get the message
> conntrack v1.00beta2: Missing arguments...

The result of getopt_long() was assigned to a char,
which defaults to unsigned on ARM, so the comparison
against -1 always failed.

[-- Attachment #2: conntrack-getopt.patch --]
[-- Type: text/plain, Size: 408 bytes --]

Index: conntrack/src/conntrack.c
===================================================================
--- conntrack/src/conntrack.c	(revision 6601)
+++ conntrack/src/conntrack.c	(working copy)
@@ -602,7 +602,7 @@
 
 int main(int argc, char *argv[])
 {
-	char c;
+	int c;
 	unsigned int command = 0, options = 0;
 	unsigned int type = 0, event_mask = 0;
 	unsigned int l3flags = 0, l4flags = 0, metaflags = 0;

  parent reply	other threads:[~2006-05-12  7:11 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-04-27 11:55 Libnetfilter_conntrack problems Sébastien LAVEZE
2006-05-01 17:53 ` Harald Welte
2006-05-03  9:49   ` Sébastien LAVEZE
2006-05-03 11:15     ` Harald Welte
2006-05-09 15:06       ` Sébastien LAVEZE
2006-05-09 15:12         ` Pablo Neira Ayuso
2006-05-10  8:18           ` Sébastien LAVEZE
2006-05-10 13:00             ` Sébastien LAVEZE
2006-05-12  8:34               ` Sébastien LAVEZE
2006-05-12  8:42                 ` Philip Craig
2006-05-12  9:01                   ` Sébastien LAVEZE
2006-05-16 10:52                     ` Pablo Neira Ayuso
2006-05-12  7:11             ` Philip Craig [this message]
2006-05-13  2:24               ` [PATCH] conntrack: Fix option parsing for ARM Patrick McHardy
2006-05-14 22:43                 ` Pablo Neira Ayuso
2006-05-15  5:52                   ` Patrick McHardy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4464351F.6000402@snapgear.com \
    --to=philipc@snapgear.com \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@eurodev.net \
    --cc=slaveze@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.