From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: ulogd2 and nflog prefix Date: Mon, 15 May 2006 11:10:24 +0200 Message-ID: <44684580.7070504@trash.net> References: <4467EC50.3030907@snapgear.com> <44681346.3000301@trash.net> <446826EF.1070004@snapgear.com> <44682889.107@trash.net> <44684441.8060502@snapgear.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Harald Welte , netfilter-devel@lists.netfilter.org Return-path: To: Philip Craig In-Reply-To: <44684441.8060502@snapgear.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Philip Craig wrote: > On 05/15/2006 05:06 PM, Patrick McHardy wrote: > >>Right, I somehow though the prefix was also configured using netlink, >>which is of course wrong. In that case I think nfnetlink_log should >>just 0-terminate the string. BTW, Is there any reason why the prefix >>is truncated to NFULNL_PREFIXLEN? > > > I just noticed that net/netfilter/nf_log.c limits the prefix to > NF_LOG_PREFIXLEN=128. Don't know if this affects the decision. Not really - if there is a second limit the minimum will be effective, but that alone is no reason to truncate it. #define NFULNL_PREFIXLEN 30 /* just like old log target */ I guess this tells us why the limit exists, but since nfnetlink_log is not compatible with the old ULOG structure anyway, this could just as well be done by the compat library.