All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@keyaccess.nl>
To: Gerd Hoffmann <kraxel@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [patch] SMP alternatives: skip with UP kernels.
Date: Mon, 15 May 2006 23:41:34 +0200	[thread overview]
Message-ID: <4468F58E.8050903@keyaccess.nl> (raw)
In-Reply-To: <44647454.3050800@suse.de>

Gerd Hoffmann wrote:

>> Yes, the #ifdef in arch/i386/kernel/module.c is a bit clumsy.
> 
> Yep, thats why.  I wanted avoid exactly that.  Having some code need to
> know that function foobar() is only available with CONFIG_BAZ is set is
> really ugly ...
> 
> The attached patch hides the magic in alternative.h and provides some
> dummy inline functions for the UP case (gcc should manage to optimize
> away these calls).  No changes in module.c.

Works for me; it doesn't easily get non-clumsy in module.c I see. Sure 
you want to keep smp_alt_once outside the #ifdef? Seems to not be doing 
anything other than being set to 1 for !SMP.

Thanks,
Rene.

  reply	other threads:[~2006-05-15 21:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10  0:30 2.6.17-rc3 -- SMP alternatives: switching to UP code Rene Herman
2006-05-10  1:55 ` Chase Venters
2006-05-10  9:28 ` Gerd Hoffmann
2006-05-10 11:41   ` Rene Herman
2006-05-11 12:13     ` [patch] SMP alternatives: skip with UP kernels Gerd Hoffmann
2006-05-11 21:07       ` Rene Herman
2006-05-12 11:41         ` Gerd Hoffmann
2006-05-15 21:41           ` Rene Herman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-05-11 16:22 Mikael Pettersson
2006-05-11 18:28 ` Andi Kleen
2006-05-11 21:18 Mikael Pettersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4468F58E.8050903@keyaccess.nl \
    --to=rene.herman@keyaccess.nl \
    --cc=kraxel@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.