All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	shemminger@osdl.org, ranjitm@google.com, akpm@osdl.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] tcpdump may trace some outbound packets twice.
Date: Tue, 16 May 2006 03:17:59 +0200	[thread overview]
Message-ID: <44692847.4080100@trash.net> (raw)
In-Reply-To: <E1FfnZP-0003St-00@gondolin.me.apana.org.au>

Herbert Xu wrote:
> David S. Miller <davem@davemloft.net> wrote:
> 
>>Other implementation possibility suggestions welcome :-)
> 
> 
> I see two possibilities:
> 
> 1) Move the af_packet hook into the NIC driver.
> 2) Rethink the lockless tx setup.  If all NICs followed the tg3 and
>    replaced spin_lock_irqsave with spin_lock then we should be able
>    to go back to just using the xmit_lock.

3) Clone the skb and have dev_queue_xmit_nit() consume it.

That should actually be pretty easy.

  reply	other threads:[~2006-05-16  1:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-10 20:17 [PATCH] tcpdump may trace some outbound packets twice Ranjit Manomohan
2006-05-14 10:10 ` Andrew Morton
2006-05-14 15:58   ` Ranjit Manomohan
2006-05-14 20:42   ` David S. Miller
2006-05-15 21:19     ` Ranjit Manomohan
2006-05-15 21:26       ` David S. Miller
2006-05-15 21:41         ` Patrick McHardy
2006-05-15 23:11         ` Ranjit Manomohan
2006-05-15 23:41           ` Stephen Hemminger
2006-05-16  0:08             ` David S. Miller
2006-05-16  0:21               ` Patrick McHardy
2006-05-16  0:48                 ` Tom Young
2006-05-16  0:37               ` Herbert Xu
2006-05-16  1:17                 ` Patrick McHardy [this message]
2006-05-16  1:20                   ` Herbert Xu
2006-05-16  1:22                   ` Patrick McHardy
2006-05-16  4:18                     ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44692847.4080100@trash.net \
    --to=kaber@trash.net \
    --cc=akpm@osdl.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ranjitm@google.com \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.