From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Jan Beulich" Subject: Re: [PATCH] blkfront: ioctls/geometry, 2.6 Date: Tue, 16 May 2006 09:18:39 +0200 Message-ID: <446998EF.76E4.0078.0@novell.com> References: <20060515181525.GA2110@bar.gandi.net> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20060515181525.GA2110@bar.gandi.net> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Pascal Bouchareine Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org We did a similar patch recently here (not submitted, yet) - so I immediately see some concerns with your patch: - Why do you need to add BLKGETSIZE and BLKGETSIZE64? block/ioctl.c is already taking care of those, they should never arrive at the driver. - The calculation of the cylinder value seems odd to me. Why don't you use sector_div() here? - There is an apparently unused variable 'dpart' left in blkif_getgeo(). Jan >>> Pascal Bouchareine 15.05.06 20:15 >>> Hi, Adds HDIO_GETGEO, BLKGETSIZE, BLKGETSIZE64 support to blkfront. An attempt to merge in the following sent previously by Ian Pratt : http://lists.xensource.com/archives/html/xen-devel/2005-01/msg00659.html Taking into account the block_device_operations for get_geom. Regards, Pascal -- \o/ Pascal Bouchareine - Gandi g 0170393757 15, place de la Nation - 75011 Paris