All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bernd Schmidt <bernds_cb1@t-online.de>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>,
	torvalds@osdl.org, "Luke.Yang" <luke.yang@analog.com>,
	Greg Ungerer <gerg@snapgear.com>
Subject: Please revert git commit 1ad3dcc0
Date: Tue, 16 May 2006 13:23:39 +0200	[thread overview]
Message-ID: <4469B63B.6000502@t-online.de> (raw)

Linus, Andrew,

please revert 1ad3dcc0.  That was a patch to the binfmt_flat loader, 
which was motivated by an LTP testcase which checks that execve returns 
EMFILE when the file descriptor table is full.

The patch is buggy: the code now keeps file descriptors open for the 
executable and its libraries, which has confused at least one 
application.  It's also unnecessary, since there is no code that uses 
the file descriptor, so the new EMFILE error return is totally artificial.

The reversion is
Signed-off-by: Bernd Schmidt <bernd.schmidt@analog.com>
Signed-off-by: Greg Ungerer <gerg@uclinux.org>
and I think Luke had no objections either.


Bernd

             reply	other threads:[~2006-05-16 11:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16 11:23 Bernd Schmidt [this message]
2006-05-16 13:58 ` Please revert git commit 1ad3dcc0 Andrew Morton
2006-05-16 14:29   ` Bernd Schmidt
2006-05-16 14:50     ` Andrew Morton
2006-05-16 14:57       ` Bernd Schmidt
2006-05-16 14:54     ` Linus Torvalds
2006-05-16 15:10       ` Bernd Schmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4469B63B.6000502@t-online.de \
    --to=bernds_cb1@t-online.de \
    --cc=akpm@osdl.org \
    --cc=gerg@snapgear.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luke.yang@analog.com \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.