All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Marcin Juszkiewicz <linux-arm@hrw.one.pl>
Cc: netdev@vger.kernel.org, Jouni Malinen <jkmaline@cc.hut.fi>,
	Pavel Roskin <proski@gnu.org>
Subject: Re: [PATCH 3/6] new pcmcia IDs for hostap - NETGEAR MA701
Date: Tue, 16 May 2006 11:01:27 -0400	[thread overview]
Message-ID: <4469E947.908@garzik.org> (raw)
In-Reply-To: <200605161648.57356.linux-arm@hrw.one.pl>

Marcin Juszkiewicz wrote:
> Dnia wtorek, 16 maja 2006 16:38, Jeff Garzik napisał:
>> Marcin Juszkiewicz wrote:
>>> One more Prism2 card which works with HostAP.
>> Please roll these into a single patch.  There's no need to split it up
>> such that there is one ID per patch.
> 
> Index: netdev-2.6/drivers/net/wireless/hostap/hostap_cs.c
> ===================================================================
> --- netdev-2.6.orig/drivers/net/wireless/hostap/hostap_cs.c	2006-05-16 16:47:27.469628352 +0200
> +++ netdev-2.6/drivers/net/wireless/hostap/hostap_cs.c	2006-05-16 16:47:48.882373120 +0200

Thanks, but you violated rules #6, #5, and #2 of
http://linux.yyz.us/patch-format.html

Also, make sure to CC John Linville, as he's the one who will actually 
be applying your patch.

Regards,

	Jeff



  reply	other threads:[~2006-05-16 15:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16 14:21 [PATCH 3/6] new pcmcia IDs for hostap - NETGEAR MA701 Marcin Juszkiewicz
2006-05-16 14:38 ` Jeff Garzik
2006-05-16 14:48   ` Marcin Juszkiewicz
2006-05-16 15:01     ` Jeff Garzik [this message]
2006-05-16 15:24   ` [PATCH 3/6] new pcmcia IDs for hostap Marcin Juszkiewicz
2006-05-16 21:15     ` Pavel Roskin
2006-05-17  8:36       ` Marcin Juszkiewicz
2006-05-17 18:45         ` John W. Linville
2006-05-17 22:03         ` Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4469E947.908@garzik.org \
    --to=jeff@garzik.org \
    --cc=jkmaline@cc.hut.fi \
    --cc=linux-arm@hrw.one.pl \
    --cc=netdev@vger.kernel.org \
    --cc=proski@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.