From: Jeff Garzik <jgarzik@pobox.com>
To: Tejun Heo <htejun@gmail.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: PATCH: Fix broken PIO with libata
Date: Tue, 16 May 2006 13:10:46 -0400 [thread overview]
Message-ID: <446A0796.5030606@pobox.com> (raw)
In-Reply-To: <4469F169.2050708@gmail.com>
Tejun Heo wrote:
> Alan Cox wrote:
>> #2 The core sets ATA_DFLAG_PIO to indicate PIO commands should be used
>> on this channel. This same information is available in dev->dma_mode but
>> for some reason we get two sources of the info. The ATA_DFLAG_PIO is set
>> once during setup and then cleared but not re-computed by the revalidate
>> function. This causes DMA commands to be issued when PIO would be and
>> usually an Oops or hang
>
> Hmmm... I tried to fix this problem in the following commit. With it,
> ATA_DFLAG_PIO isn't cleared over ata_dev_configure(). Only
> ata_dev_set_mode() is allowed to diddle with it and does about the same
> thing as your patch does.
I presume he's looking at what users will hit when 2.6.17 is released...
Jeff
prev parent reply other threads:[~2006-05-16 17:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 14:39 PATCH: Fix broken PIO with libata Alan Cox
2006-05-16 15:33 ` Kevin Radloff
2006-05-16 15:53 ` Alan Cox
2006-05-16 17:19 ` Kevin Radloff
2006-05-16 17:27 ` Jeff Garzik
2006-05-16 17:39 ` Tejun Heo
2006-05-16 18:13 ` Kevin Radloff
2006-05-16 22:51 ` Alan Cox
2006-05-16 15:36 ` Tejun Heo
2006-05-16 15:48 ` Jeff Garzik
2006-05-16 15:57 ` Tejun Heo
2006-05-16 23:00 ` Paul Mackerras
2006-05-16 17:10 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A0796.5030606@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.