From: Jeff Garzik <jeff@garzik.org>
To: Andre Hedrick <andre@linux-ide.org>
Cc: linux-scsi@vger.kernel.org, Seokmann.Ju@lsil.com,
Andrew Morton <akpm@osdl.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
Christoph Hellwig <hch@infradead.org>,
Atul Mukker <Atul.Mukker@lsil.com>
Subject: Re: [RFC] Megaraid update, submission
Date: Tue, 16 May 2006 14:07:00 -0400 [thread overview]
Message-ID: <446A14C4.8050002@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.10.10605161020140.3589-200000@master.linux-ide.org>
Andre Hedrick wrote:
> +static int megaraid_pci_master_abort(struct pci_dev* dev)
> +{
> + u16 status, error_bits;
> +
> + pci_read_config_word(dev, PCI_STATUS, &status);
> + if (error_bits)
> + pci_write_config_word(dev, PCI_STATUS, error_bits);
> + pci_read_config_word(dev, PCI_STATUS, &status);
error_bits is used before a value is assigned to it. Presumably you are
missing a duplicate of a line further down in the function,
error_bits = (status & PCI_STATUS_REC_MASTER_ABORT);
The list stuff looks OK, to my quick glance.
Jeff
next prev parent reply other threads:[~2006-05-16 18:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-04 18:48 megaraid_mbox: garbage in file Vasily Averin
2006-05-04 22:59 ` James Bottomley
2006-05-05 5:37 ` Vasily Averin
2006-05-05 9:21 ` Vasily Averin
2006-05-16 17:44 ` [RFC] Megaraid update, submission Andre Hedrick
2006-05-16 18:07 ` Jeff Garzik [this message]
2006-05-16 18:13 ` Andre Hedrick
2006-05-16 19:44 ` Matthew Wilcox
2006-05-16 20:24 ` Andre Hedrick
2006-05-05 15:59 ` megaraid_mbox: garbage in file James Bottomley
2006-05-05 18:17 ` Vasily Averin
2006-05-05 20:05 ` James Bottomley
2006-05-05 23:43 ` Vasily Averin
2006-05-05 23:43 ` Vasily Averin
-- strict thread matches above, loose matches on Subject: below --
2006-05-16 19:03 [RFC] Megaraid update, submission Ju, Seokmann
2006-05-16 20:47 ` Andre Hedrick
2006-05-16 21:08 Ju, Seokmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A14C4.8050002@garzik.org \
--to=jeff@garzik.org \
--cc=Atul.Mukker@lsil.com \
--cc=James.Bottomley@SteelEye.com \
--cc=Seokmann.Ju@lsil.com \
--cc=akpm@osdl.org \
--cc=andre@linux-ide.org \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.