* Re: [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by
2006-05-16 21:57 [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by trem
@ 2006-05-16 22:10 ` Greg KH
2006-05-16 22:45 ` trem
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2006-05-16 22:10 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 429 bytes --]
On Tue, May 16, 2006 at 11:57:46PM +0200, trem wrote:
> From: trem <tremyfr@yahoo.fr>
>
> This patch simply change pci_find_device by pci_get_device, because
> pci_find_device is deprecated. pci_dev_put has been added to decrement
> the counter, so unload could be done.
Huh? No, this patch is wrong, you are leaking a reference count, and
causing others to drop down to 0 accidentally.
Do NOT apply this.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 5+ messages in thread* [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by
2006-05-16 21:57 [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by trem
2006-05-16 22:10 ` Greg KH
@ 2006-05-16 22:45 ` trem
2006-05-17 0:18 ` Greg KH
2006-05-20 0:50 ` [KJ] [PATCH] drivers/char/istallion.c : replace " trem
3 siblings, 0 replies; 5+ messages in thread
From: trem @ 2006-05-16 22:45 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
From: trem <tremyfr@yahoo.fr>
This patch simply change pci_find_device by pci_get_device, because
pci_find_device is deprecated. pci_dev_put has been added to decrement
the counter, so unload could be done. I've added a pci_dev_put(dev)
before the return to avoid missing one device (thanks greg k-h for the
remark)
Signed-Off-By: trem <tremyfr@yahoo.fr>
---
[-- Attachment #2: istallion_replace_pci_find_device_by_pci_get_device.patch --]
[-- Type: text/x-patch, Size: 586 bytes --]
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
index ef20c1f..b10eea7 100644
--- a/drivers/char/istallion.c
+++ b/drivers/char/istallion.c
@@ -4576,10 +4576,13 @@ static int stli_findpcibrds(void)
printk("stli_findpcibrds()\n");
#endif
- while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
+ while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION,
PCI_DEVICE_ID_ECRA, dev))) {
- if ((rc = stli_initpcibrd(BRD_ECPPCI, dev)))
+ if ((rc = stli_initpcibrd(BRD_ECPPCI, dev))) {
+ pci_dev_put(dev);
return(rc);
+ }
+ pci_dev_put(dev);
}
return(0);
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by
2006-05-16 21:57 [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by trem
2006-05-16 22:10 ` Greg KH
2006-05-16 22:45 ` trem
@ 2006-05-17 0:18 ` Greg KH
2006-05-20 0:50 ` [KJ] [PATCH] drivers/char/istallion.c : replace " trem
3 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2006-05-17 0:18 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]
On Wed, May 17, 2006 at 12:45:54AM +0200, trem wrote:
> From: trem <tremyfr@yahoo.fr>
>
> This patch simply change pci_find_device by pci_get_device, because
> pci_find_device is deprecated. pci_dev_put has been added to decrement
> the counter, so unload could be done. I've added a pci_dev_put(dev)
> before the return to avoid missing one device (thanks greg k-h for the
> remark)
>
> Signed-Off-By: trem <tremyfr@yahoo.fr>
> ---
>
> diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
> index ef20c1f..b10eea7 100644
> --- a/drivers/char/istallion.c
> +++ b/drivers/char/istallion.c
> @@ -4576,10 +4576,13 @@ static int stli_findpcibrds(void)
> printk("stli_findpcibrds()\n");
> #endif
>
> - while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
> + while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION,
> PCI_DEVICE_ID_ECRA, dev))) {
> - if ((rc = stli_initpcibrd(BRD_ECPPCI, dev)))
> + if ((rc = stli_initpcibrd(BRD_ECPPCI, dev))) {
> + pci_dev_put(dev);
> return(rc);
> + }
> + pci_dev_put(dev);
No, this is still wrong. Please read the documentation on how to use
this function.
thanks,
greg k-h
[-- Attachment #2: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply [flat|nested] 5+ messages in thread* [KJ] [PATCH] drivers/char/istallion.c : replace pci_find_device by
2006-05-16 21:57 [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by trem
` (2 preceding siblings ...)
2006-05-17 0:18 ` Greg KH
@ 2006-05-20 0:50 ` trem
3 siblings, 0 replies; 5+ messages in thread
From: trem @ 2006-05-20 0:50 UTC (permalink / raw)
To: kernel-janitors
[-- Attachment #1: Type: text/plain, Size: 277 bytes --]
From: trem <tremyfr@yahoo.fr>
This patch simply change pci_find_device by pci_get_device, because
pci_find_device is deprecated. pci_dev_put has been added to decrement
the counter when the loop is broken, so unload could be done.
Signed-Off-By: trem <tremyfr@yahoo.fr>
---
[-- Attachment #2: istallion_replace_pci_find_device_by_pci_get_device.patch --]
[-- Type: text/x-patch, Size: 565 bytes --]
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
index ef20c1f..83002d5 100644
--- a/drivers/char/istallion.c
+++ b/drivers/char/istallion.c
@@ -4576,10 +4576,12 @@ static int stli_findpcibrds(void)
printk("stli_findpcibrds()\n");
#endif
- while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
+ while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION,
PCI_DEVICE_ID_ECRA, dev))) {
- if ((rc = stli_initpcibrd(BRD_ECPPCI, dev)))
+ if ((rc = stli_initpcibrd(BRD_ECPPCI, dev))) {
+ pci_dev_put(dev);
return(rc);
+ }
}
return(0);
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
^ permalink raw reply related [flat|nested] 5+ messages in thread