From: trem <tremyfr@yahoo.fr>
To: kernel-janitors@vger.kernel.org
Subject: [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by
Date: Tue, 16 May 2006 22:45:54 +0000 [thread overview]
Message-ID: <446A5622.4070308@yahoo.fr> (raw)
In-Reply-To: <446A4ADA.3070606@yahoo.fr>
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
From: trem <tremyfr@yahoo.fr>
This patch simply change pci_find_device by pci_get_device, because
pci_find_device is deprecated. pci_dev_put has been added to decrement
the counter, so unload could be done. I've added a pci_dev_put(dev)
before the return to avoid missing one device (thanks greg k-h for the
remark)
Signed-Off-By: trem <tremyfr@yahoo.fr>
---
[-- Attachment #2: istallion_replace_pci_find_device_by_pci_get_device.patch --]
[-- Type: text/x-patch, Size: 586 bytes --]
diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
index ef20c1f..b10eea7 100644
--- a/drivers/char/istallion.c
+++ b/drivers/char/istallion.c
@@ -4576,10 +4576,13 @@ static int stli_findpcibrds(void)
printk("stli_findpcibrds()\n");
#endif
- while ((dev = pci_find_device(PCI_VENDOR_ID_STALLION,
+ while ((dev = pci_get_device(PCI_VENDOR_ID_STALLION,
PCI_DEVICE_ID_ECRA, dev))) {
- if ((rc = stli_initpcibrd(BRD_ECPPCI, dev)))
+ if ((rc = stli_initpcibrd(BRD_ECPPCI, dev))) {
+ pci_dev_put(dev);
return(rc);
+ }
+ pci_dev_put(dev);
}
return(0);
[-- Attachment #3: Type: text/plain, Size: 168 bytes --]
_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors
next prev parent reply other threads:[~2006-05-16 22:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 21:57 [KJ] [PATCH] drivers/char/istallion.c : change pci_find_device by trem
2006-05-16 22:10 ` Greg KH
2006-05-16 22:45 ` trem [this message]
2006-05-17 0:18 ` Greg KH
2006-05-20 0:50 ` [KJ] [PATCH] drivers/char/istallion.c : replace " trem
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446A5622.4070308@yahoo.fr \
--to=tremyfr@yahoo.fr \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.