From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: Re: [PATCH] fix mem-leak in netfilter Date: Wed, 17 May 2006 09:19:15 +0200 Message-ID: <446ACE73.604@trash.net> References: <20060515204142.GO7774@kenobi.snowman.net> <20060515210342.GP7774@kenobi.snowman.net> <446AC1FB.5070406@trash.net> <20060517.000957.45395448.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: sfrost@snowman.net, azez@ufomechanic.net, willy@w.ods.org, gcoady.lk@gmail.com, laforge@netfilter.org, netfilter-devel@lists.netfilter.org, linux-kernel@vger.kernel.org, marcelo@kvack.org Return-path: To: "David S. Miller" In-Reply-To: <20060517.000957.45395448.davem@davemloft.net> Sender: linux-kernel-owner@vger.kernel.org List-Id: netfilter-devel.vger.kernel.org David S. Miller wrote: > From: Patrick McHardy > Date: Wed, 17 May 2006 08:26:03 +0200 > > >>+ if (info->check_set & (IPT_RECENT_SET | IPT_RECENT_REMOVE) && >>+ (info->seconds || info->hit_count)) >>+ return 0; > > > I'm feeling particularly dense today... but what is the relative > precedence of '&' vs '&&'? > > I've been told that if you have to look up C operator precedence, > don't bother and add parenthesis instead :) Bitwise AND has precedence, but I have no problems adding an extra set of parenthesis around it :)