All of lore.kernel.org
 help / color / mirror / Atom feed
From: Philip Craig <philipc@snapgear.com>
To: netfilter-devel <netfilter-devel@lists.netfilter.org>
Subject: [PATCH] libnetfilter_conntrack: link extensions against libnfnetlink
Date: Wed, 17 May 2006 17:24:08 +1000	[thread overview]
Message-ID: <446ACF98.1090509@snapgear.com> (raw)

The ulogd NFCT plugin fails to load libnetfilter_conntrack extensions
unless they are linked against libnfnetlink.  This problem may be
specific to uClibc.

Also, a couple of questions about these makefiles:

Is there any reason to have a separate LIBADD for each extension?

Why is LIBS set in these files?  This is normally a user defined variable,
with the default value being determined by configure.  And since we do
a AC_CHECK_LIB for nfnetlink, the default LIBS already contains -lnfnetlink.

Index: libnetfilter_conntrack/extensions/Makefile.am
===================================================================
--- libnetfilter_conntrack/extensions/Makefile.am	(revision 6601)
+++ libnetfilter_conntrack/extensions/Makefile.am	(working copy)
@@ -10,16 +10,16 @@

 nfct_proto_tcp_la_SOURCES = libnetfilter_conntrack_tcp.c
 nfct_proto_tcp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_tcp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_tcp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink

 nfct_proto_udp_la_SOURCES = libnetfilter_conntrack_udp.c
 nfct_proto_udp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_udp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_udp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink

 nfct_proto_icmp_la_SOURCES = libnetfilter_conntrack_icmp.c
 nfct_proto_icmp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_icmp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_icmp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink

 nfct_proto_sctp_la_SOURCES = libnetfilter_conntrack_sctp.c
 nfct_proto_sctp_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_proto_sctp_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_proto_sctp_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink
Index: libnetfilter_conntrack/l3extensions/Makefile.am
===================================================================
--- libnetfilter_conntrack/l3extensions/Makefile.am	(revision 6601)
+++ libnetfilter_conntrack/l3extensions/Makefile.am	(working copy)
@@ -9,8 +9,8 @@

 nfct_l3proto_ipv4_la_SOURCES = libnetfilter_conntrack_ipv4.c
 nfct_l3proto_ipv4_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_l3proto_ipv4_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_l3proto_ipv4_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink

 nfct_l3proto_ipv6_la_SOURCES = libnetfilter_conntrack_ipv6.c
 nfct_l3proto_ipv6_la_LDFLAGS = -module -avoid-version -release $(VERSION)
-nfct_l3proto_ipv6_la_LIBADD = ../src/libnetfilter_conntrack.la
+nfct_l3proto_ipv6_la_LIBADD = ../src/libnetfilter_conntrack.la -lnfnetlink

                 reply	other threads:[~2006-05-17  7:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446ACF98.1090509@snapgear.com \
    --to=philipc@snapgear.com \
    --cc=netfilter-devel@lists.netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.