From: "H. Peter Anvin" <hpa@zytor.com>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: linux-kernel@vger.kernel.org,
Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate
Date: Thu, 18 May 2006 15:38:27 -0700 [thread overview]
Message-ID: <446CF763.6020209@zytor.com> (raw)
In-Reply-To: <200605190032.25796.ioe-lkml@rameria.de>
Ingo Oeser wrote:
> Hi Hans Peter,
>
> H. Peter Anvin wrote
>> ENOIOCTLCMD is right here, *except* in the very last hunk, because
>> it's a request to the upper layers to emulate the operation:
>
> So would a patch like this be welcome and clear this up?
>
> diff --git a/include/linux/errno.h b/include/linux/errno.h
> index d90b80f..d33ae4b 100644
> --- a/include/linux/errno.h
> +++ b/include/linux/errno.h
> @@ -9,7 +9,7 @@
> #define ERESTARTSYS 512
> #define ERESTARTNOINTR 513
> #define ERESTARTNOHAND 514 /* restart if no handler.. */
> -#define ENOIOCTLCMD 515 /* No ioctl command */
> +#define ENOIOCTLCMD 515 /* No ioctl command, upper layer please emulate or pass ENOTTY to user space */
> #define ERESTART_RESTARTBLOCK 516 /* restart by calling sys_restart_syscall */
>
> /* Defined for the NFSv3 protocol */
>
Sure, if people feel it's necessary.
-hpa
prev parent reply other threads:[~2006-05-18 22:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-16 23:30 [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate Alessandro Zummo
2006-05-17 21:25 ` Randy.Dunlap
2006-05-17 21:27 ` Alessandro Zummo
2006-05-18 20:30 ` H. Peter Anvin
2006-05-18 22:32 ` Ingo Oeser
2006-05-18 22:38 ` H. Peter Anvin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=446CF763.6020209@zytor.com \
--to=hpa@zytor.com \
--cc=alessandro.zummo@towertech.it \
--cc=ioe-lkml@rameria.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.