All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shankar Anand" <shanand@novell.com>
To: "J. Bruce Fields"<bfields@fieldses.org>,<nfsv4@linux-nfs.org>,
	<nfs@lists.sourceforge.net>
Subject: Re: PATCH[2/2] Display nfsv4 server operations statistics
Date: Fri, 19 May 2006 09:32:38 -0600	[thread overview]
Message-ID: <446E326E.AD69.00CC.0@novell.com> (raw)
In-Reply-To: <4469C83D.AD69.00CC.0@novell.com>

[-- Attachment #1: Type: text/plain, Size: 338 bytes --]


Changed 'Submitted by' to 'Signed-off-by' and attached the patch here.

- Shankar

> On 5/16/2006 at 12:40:28 pm, in message,
> "Shankar Anand" <shanand@novell.com> wrote:
> This patch adds code to nfsstat to read /proc/net/rpc/nfsd for nfsv4
> server statistics and print them.
> 
> Submitted by: Shankar Anand <shanand@novell.com>
> 


[-- Attachment #2: nfs-utils-1.0.8-display-nfs4-server-stats.diff --]
[-- Type: text/plain, Size: 2685 bytes --]

This patch adds code to nfsstat to read /proc/net/rpc/nfsd for nfsv4 server statistics and print them.

Signed-off-by: Shankar Anand<shanand@novell.com>

diff -aurp nfs-utils-1.0.8.old/utils/nfsstat/nfsstat.c nfs-utils-1.0.8/utils/nfsstat/nfsstat.c
--- nfs-utils-1.0.8.old/utils/nfsstat/nfsstat.c	2005-12-20 09:42:47.000000000 +0530
+++ nfs-utils-1.0.8/utils/nfsstat/nfsstat.c	2006-05-16 16:56:18.000000000 +0530
@@ -29,6 +29,7 @@ static unsigned int	svcv3info[24];	/* NF
 static unsigned int	cltv3info[24];	/* NFSv3 call counts ([0] == 22) */
 static unsigned int	svcv4info[4];	/* NFSv4 call counts ([0] == 2) */
 static unsigned int	cltv4info[34];	/* NFSv4 call counts ([0] == 32) */
+static unsigned int	svcv4opinfo[39];/* NFSv4 call counts ([0] == 37) */
 static unsigned int	svcnetinfo[5];	/* 0  # of received packets
 					 * 1  UDP packets
 					 * 2  TCP packets
@@ -99,6 +100,16 @@ static const char *	nfscltv4name[32] = {
 	"statfs",    "readlink",  "readdir", "server_caps", "delegreturn",
 };
 
+static const char *     nfssvrv4opname[37] = {
+        "access",    "close",       "commit",   "create",       "delegpurge", "delegreturn",
+        "getattr",   "getfh",       "link",     "lock",         "lockt",      "locku",
+        "lookup",    "lookup_root", "nverify",  "open",         "openattr",   "open_conf",
+        "open_dgrd", "putfh",       "putpubfh", "putrootfh",    "read",       "readdir",
+        "readlink",  "remove",      "rename",   "renew",        "restorefh",  "savefh",
+        "secinfo",   "setattr",     "setcltid", "setcltidconf", "verify",     "write",
+        "rellockowner"
+};
+
 typedef struct statinfo {
 	char		*tag;
 	int		nrvals;
@@ -115,6 +126,7 @@ static statinfo		svcinfo[] = {
 	{ "proc2",      STRUCTSIZE(svcv2info),  svcv2info  },
 	{ "proc3",      STRUCTSIZE(svcv3info),  svcv3info  },
 	{ "proc4",      STRUCTSIZE(svcv4info),  svcv4info  },
+	{ "proc4ops",   STRUCTSIZE(svcv4opinfo),svcv4opinfo},
 	{ NULL,         0,                      NULL       }
 };
 
@@ -381,11 +393,16 @@ main(int argc, char **argv)
 				"Server nfs v3:\n",
 				nfsv3name, svcv3info + 1, sizeof(nfsv3name)/sizeof(char *)
 				);
-			if ((opt_prt & PRNT_V4) || ((opt_prt & PRNT_AUTO) && svcv4info[0] && svcv4info[svcv4info[0]+1] != svcv4info[0]))
+			if ((opt_prt & PRNT_V4) || ((opt_prt & PRNT_AUTO) && svcv4info[0] && svcv4info[svcv4info[0]+1] != svcv4info[0])) {
 				print_callstats(
 				"Server nfs v4:\n",
 				nfssvrv4name, svcv4info + 1, sizeof(nfssvrv4name)/sizeof(char *)
 				);
+				print_callstats(
+				"Server nfs v4 operations:\n",
+				nfssvrv4opname, svcv4opinfo + 1, sizeof(nfssvrv4opname)/sizeof(char *)
+				);
+			}
 		}
 	}
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
NFSv4 mailing list
NFSv4@linux-nfs.org
http://linux-nfs.org/cgi-bin/mailman/listinfo/nfsv4

      parent reply	other threads:[~2006-05-19 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-16  7:10 PATCH[2/2] Display nfsv4 server operations statistics Shankar Anand
2006-05-17 21:38 ` J. Bruce Fields
2006-05-19 15:32 ` Shankar Anand [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=446E326E.AD69.00CC.0@novell.com \
    --to=shanand@novell.com \
    --cc=bfields@fieldses.org \
    --cc=nfs@lists.sourceforge.net \
    --cc=nfsv4@linux-nfs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.