From: Derek M Jones <derek@knosof.co.uk>
To: "Jörn Engel" <joern@wohnheim.fh-wedel.de>
Cc: Michael Buesch <mb@bu3sch.de>, linux-sparse@vger.kernel.org
Subject: Re: [PATCH] let sparse warn on &inline_function
Date: Mon, 22 May 2006 11:06:49 +0100 [thread overview]
Message-ID: <44718D39.4020000@knosof.co.uk> (raw)
In-Reply-To: <20060522083650.GA19072@wohnheim.fh-wedel.de>
Jörn,
>>>> It makes perfect sense for me to want 'direct' calls to be
>>>> inlined and be willing to accept that calls via pointers
>>>> will not be inlined.
>>> Does this still make sense with CONFIG_CC_OPTIMIZE_FOR_SIZE set?
>> Using the inline specifier may or may not make sense in this case.
>
> And this is exactly what warnings are all about. If the code in
> question may make sense, but there is a certain likelyhood that it
> does not, print a warning.
In which case the message needs to be changed to flag the function
definition that contains the inline function specifier, not the point
at which it is the operand of an address-of operator.
--
Derek M. Jones tel: +44 (0) 1252 520 667
Knowledge Software Ltd mailto:derek@knosof.co.uk
Applications Standards Conformance Testing http://www.knosof.co.uk
prev parent reply other threads:[~2006-05-22 10:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-20 14:21 [PATCH] let sparse warn on &inline_function Michael Buesch
2006-05-20 15:10 ` Derek M Jones
2006-05-20 15:34 ` Michael Buesch
2006-05-20 15:53 ` Derek M Jones
2006-05-21 19:37 ` Jörn Engel
2006-05-21 22:37 ` Derek M Jones
2006-05-22 8:36 ` Jörn Engel
2006-05-22 10:06 ` Derek M Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44718D39.4020000@knosof.co.uk \
--to=derek@knosof.co.uk \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-sparse@vger.kernel.org \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.