From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick McHardy Subject: EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL Date: Mon, 22 May 2006 18:01:23 +0200 Message-ID: <4471E053.2090601@trash.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Cc: Netfilter Development Mailinglist Return-path: To: yasuyuki.kozakai@toshiba.co.jp List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: netfilter-devel-bounces@lists.netfilter.org Errors-To: netfilter-devel-bounces@lists.netfilter.org List-Id: netfilter-devel.vger.kernel.org Hi Yasuyuki, while doing some stupid cleanup work on the conntrack code (moving all EXPORT_SYMBOLs next to the exported function) I noticed nf_conntrack uses EXPORT_SYMBOL for the exact same functions that are EXPORT_SYMBOL_GPL'ed by ip_conntrack. I think we should change it to _GPL too for consistency and because most of them mess deeply inside the internals of conntrack. Any objections to this change?