All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zach Brown <zach.brown@oracle.com>
To: Andrew Morton <akpm@osdl.org>
Cc: rdunlap@xenotime.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kmap tracking
Date: Mon, 22 May 2006 10:58:54 -0700	[thread overview]
Message-ID: <4471FBDE.8010506@oracle.com> (raw)
In-Reply-To: <20060522103915.53e03867.akpm@osdl.org>


> I was scratching my head over this patch trying to think of any bug in
> recent years which it would have detected.  I failed.

2.4 nfs used to require that it be able to kmap entire RPCs for them to
make forward progress.  Its file->write() required RPC forward progress
before it would return.  And some callers were holding kmaps across
file->write() calls.  So with enough concurrent callers doing that the
system would get stuck.

We used the patch to see who the callers were when the system got into
that state.

One of them was core dumping, believe it or not.  2.6 elf_core_dump()
still holds a kmap across file->write(), which seems unwise, but I
haven't gotten to seeing if it's worth worrying about or not.

So maybe these days the kmap story is less dreadful and it isn't as
helpful, but that's what we used it for.

- z

  reply	other threads:[~2006-05-22 17:59 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-18 22:53 [PATCH] kmap tracking Randy.Dunlap
2006-05-22 16:43 ` Zach Brown
2006-05-22 17:39   ` Andrew Morton
2006-05-22 17:58     ` Zach Brown [this message]
2006-05-22 18:11       ` Randy.Dunlap
2006-05-23 18:42   ` Randy.Dunlap
2006-05-24  1:59     ` Randy.Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4471FBDE.8010506@oracle.com \
    --to=zach.brown@oracle.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@xenotime.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.