All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Mark Lord <liml@rtr.ca>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Al Viro <viro@zeniv.linux.org.uk>,
	linux-ide@vger.kernel.org
Subject: Re: [PATCH] sata_mv: endian annotations
Date: Mon, 22 May 2006 19:16:33 -0400	[thread overview]
Message-ID: <44724651.9070605@pobox.com> (raw)
In-Reply-To: <200605221902.03541.liml@rtr.ca>

Mark Lord wrote:
> On Monday 22 May 2006 18:56, Mark Lord wrote:
>> On Monday 22 May 2006 02:37, Jeff Garzik wrote:
>>> Alexey Dobriyan wrote:
>>>> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
>>> Unless Mark objects, I'll merge this into #upstream (2.6.18) soon.
>>>
>>> 	Jeff
>> Well, if we're going to use the endian annotation types,
>> then we may as well mark *all* of the __le* hardware fields,
>> not just a few of them.
>>
>> Thus, this extended version of Alexey's original patch:
> 
> Okay, for real this time:
> 
> Signed-off-by: Mark Lord <liml@rtr.ca>

Thanks, it's in my 'Pending' folder now.

If you would, install sparse and make sure 'make check' (kernel makefile 
target) continues to be happy with sata_mv.  That's largely what the 
endian types are for -- advanced source analysis tools like sparse.

	Jeff




      reply	other threads:[~2006-05-22 23:16 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-21 11:51 [PATCH] sata_mv: endian annotations Alexey Dobriyan
2006-05-22  6:37 ` Jeff Garzik
2006-05-22 22:56   ` Mark Lord
2006-05-22 22:58     ` Mark Lord
2006-05-22 23:02     ` Mark Lord
2006-05-22 23:16       ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44724651.9070605@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=adobriyan@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.