From: Jeff Garzik <jeff@garzik.org>
To: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>
Cc: Tejun Heo <htejun@gmail.com>
Subject: Random libata comments...
Date: Mon, 22 May 2006 19:26:49 -0400 [thread overview]
Message-ID: <447248B9.6040304@garzik.org> (raw)
* I agree with others that using the "ata_drive_probe_reset" can lead to
confusion on the uses of the word "drive". Replacing that with "do" or
something else would be nice.
* As the ata_drive_probe_reset argument list continues to grow, I lean
more and more towards moving all those function pointers to struct
ata_port_operations. One of the problems with the drivers/ide layer IMO
is that the list of all hooks used is not immediately clear upon first
read, whereas with libata it is clear -- with the notable exception of
ata_drive_probe_reset().
next reply other threads:[~2006-05-22 23:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 23:26 Jeff Garzik [this message]
2006-05-22 23:46 ` Random libata comments Tejun Heo
2006-05-22 23:55 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447248B9.6040304@garzik.org \
--to=jeff@garzik.org \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.