All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Kent <raven@themaw.net>
To: Badari Pulavarty <pbadari@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>, christoph <hch@lst.de>,
	Benjamin LaHaise <bcrl@kvack.org>,
	cel@citi.umich.edu, Zach Brown <zach.brown@oracle.com>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] Remove readv/writev methods and use	aio_read/aio_write instead
Date: Tue, 23 May 2006 16:29:21 +0800	[thread overview]
Message-ID: <4472C7E1.3060004@themaw.net> (raw)
In-Reply-To: <1148318671.7214.42.camel@dyn9047017100.beaverton.ibm.com>

Badari Pulavarty wrote:
> On Mon, 2006-05-22 at 10:06 -0700, Andrew Morton wrote:
>> Badari Pulavarty <pbadari@us.ibm.com> wrote:
>>> On Sun, 2006-05-21 at 18:00 -0700, Andrew Morton wrote:
>>>> Badari Pulavarty <pbadari@us.ibm.com> wrote:
>>>>> This patch removes readv() and writev() methods and replaces
>>>>>  them with aio_read()/aio_write() methods.
>>>> And it breaks autofs4
>>>>
>>>> autofs: pipe file descriptor does not contain proper ops
>>>>
>>> Any easy test case to reproduce the problem ?
>>>
>> Grab an FC5 setup, copy RH's .config into your tree.
> 
> Will do. 
> 
> Like I mentioned, I am travelling this week. I would really
> appreciate if someone could test my updated patch (I sent out
> in my earlier mail).

Doesn't seem to apply to 2.6.17-rc4.

[raven@raven linux-2.6.16]$ patch -p1 < 
~/remove-readv_writev-methods-and-use-aio_read_aio_write.patch
patching file drivers/char/raw.c
Hunk #1 succeeded at 270 (offset 12 lines).
patching file drivers/net/tun.c
patching file fs/bad_inode.c
patching file fs/block_dev.c
Hunk #1 succeeded at 1101 (offset 8 lines).
patching file fs/cifs/cifsfs.c
Hunk #1 FAILED at 484.
1 out of 3 hunks FAILED -- saving rejects to file fs/cifs/cifsfs.c.rej
patching file fs/compat.c
patching file fs/ext2/file.c
patching file fs/ext3/file.c
Hunk #1 succeeded at 111 (offset -1 lines).
patching file fs/fat/file.c
patching file fs/fuse/dev.c
patching file fs/hostfs/hostfs_kern.c
patching file fs/jfs/file.c
patching file fs/ntfs/file.c
Hunk #1 succeeded at 2298 (offset 2 lines).
patching file fs/pipe.c
patching file fs/read_write.c
Hunk #2 succeeded at 439 (offset -12 lines).
Hunk #4 succeeded at 574 (offset -12 lines).
Hunk #6 succeeded at 619 (offset -12 lines).
patching file fs/read_write.h
patching file fs/xfs/linux-2.6/xfs_file.c
Hunk #1 succeeded at 131 with fuzz 1 (offset 2 lines).
Hunk #3 succeeded at 513 (offset 2 lines).
patching file include/linux/fs.h
patching file mm/filemap.c
Hunk #1 succeeded at 2300 (offset 2 lines).
patching file net/socket.c
Hunk #3 FAILED at 732.
Hunk #4 FAILED at 774.
2 out of 4 hunks FAILED -- saving rejects to file net/socket.c.rej
patching file sound/core/pcm_native.c
[raven@raven linux-2.6.16]$

Ian

  reply	other threads:[~2006-05-23  8:29 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-02 15:07 [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Badari Pulavarty
2006-05-02 15:08 ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-02 15:20   ` Chuck Lever
2006-05-02 15:35     ` Badari Pulavarty
2006-05-02 15:09 ` [PATCH 2/3] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-02 15:11 ` [PATCH 3/3] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-09 18:03 ` [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Badari Pulavarty
2006-05-09 18:07   ` [PATCH 1/3] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-09 19:01     ` Andrew Morton
2006-05-09 19:03       ` Christoph Hellwig
2006-05-09 19:13         ` Andrew Morton
2006-05-09 19:20           ` Christoph Hellwig
2006-05-09 23:57             ` Badari Pulavarty
2006-05-10  8:00               ` Christoph Hellwig
2006-05-10 15:01                 ` Badari Pulavarty
2006-05-10 16:01             ` Badari Pulavarty
2006-05-10 20:50           ` Badari Pulavarty
2006-05-09 20:07         ` Badari Pulavarty
2006-05-09 23:53       ` Badari Pulavarty
2006-05-09 18:07   ` [PATCH 2/3] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-09 18:08   ` [PATCH 3/3] Zach's core aio changes to support vectored AIO Badari Pulavarty
2006-05-09 18:55     ` christoph
2006-05-09 20:05       ` Badari Pulavarty
2006-05-09 18:14   ` [PATCH 0/3] VFS changes to collapse AIO and vectored IO into single (set of) fileops Benjamin LaHaise
2006-05-11 15:38   ` [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-05-11 15:38     ` [PATCH 1/4] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-11 18:39       ` Andrew Morton
2006-05-11 19:33         ` Mark Fasheh
2006-05-11 18:47       ` Andrew Morton
2006-05-11 19:07         ` Badari Pulavarty
2006-05-11 20:21           ` Andrew Morton
2006-05-11 20:45             ` Badari Pulavarty
     [not found]               ` <4463AB55.2010105@citi.umich.edu>
     [not found]                 ` <4463B368.9050602@us.ibm.com>
     [not found]                   ` <4463B7B0.4000102@citi.umich.edu>
2006-05-11 22:50                     ` Badari Pulavarty
2006-05-12  7:38                       ` Christoph Hellwig
2006-05-11 18:52       ` Andrew Morton
2006-05-11 19:12         ` Badari Pulavarty
2006-05-12 10:03       ` Andrew Morton
2006-05-12 10:08         ` Andrew Morton
2006-05-12 13:56           ` Badari Pulavarty
2006-05-11 15:40     ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-11 15:42     ` [PATCH 3/4] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-11 15:43     ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-05-15 21:19     ` [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-05-15 21:21       ` [PATCH 1/4] Vectorize aio_read/aio_write methods Badari Pulavarty
2006-05-15 21:22       ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-05-22  1:00         ` Andrew Morton
2006-05-22  4:39           ` Badari Pulavarty
2006-05-22  5:34           ` Christoph Hellwig
2006-05-22  8:16             ` Ian Kent
2006-05-22  8:19             ` Ian Kent
2006-05-22  9:29             ` Andrew Morton
2006-05-22  9:35               ` Andrew Morton
2006-05-22 10:32                 ` Christoph Hellwig
2006-05-22 10:44                   ` Andrew Morton
2006-05-22 10:50                   ` Ian Kent
2006-05-22 15:24             ` Badari Pulavarty
2006-05-22 15:00           ` Badari Pulavarty
2006-05-22 17:06             ` Andrew Morton
2006-05-22 17:24               ` Badari Pulavarty
2006-05-23  8:29                 ` Ian Kent [this message]
2006-05-23 14:35                   ` Ian Kent
2006-05-28  0:15                     ` Badari Pulavarty
2006-05-29  7:06                       ` Ian Kent
2006-05-15 21:22       ` [PATCH 3/4] Core aio changes to support vectored AIO Badari Pulavarty
2006-05-15 21:23       ` [PATCH 4/4] Streamline generic_file_* interfaces and filemap cleanups Badari Pulavarty
2006-05-15 22:28         ` Nathan Scott
2006-05-15 22:42           ` Andrew Morton
2006-05-15 22:56             ` Nathan Scott
2006-05-15 22:47           ` Badari Pulavarty
2006-05-16 10:50           ` christoph
  -- strict thread matches above, loose matches on Subject: below --
2006-06-02 19:06 [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO (2.6.17-rc5-mm2) Badari Pulavarty
2006-06-02 19:08 ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty
2006-06-13 23:32 [PATCH 0/4] VFS fileop cleanups by collapsing AIO and vector IO Badari Pulavarty
2006-06-13 23:33 ` [PATCH 2/4] Remove readv/writev methods and use aio_read/aio_write instead Badari Pulavarty

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4472C7E1.3060004@themaw.net \
    --to=raven@themaw.net \
    --cc=akpm@osdl.org \
    --cc=bcrl@kvack.org \
    --cc=cel@citi.umich.edu \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbadari@us.ibm.com \
    --cc=zach.brown@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.