From: Patrick McHardy <kaber@trash.net>
To: Jing Min Zhao <zhaojingmin@hotmail.com>
Cc: Netfilter Development Mailinglist
<netfilter-devel@lists.netfilter.org>,
Jing Min Zhao <zhaojingmin@users.sourceforge.net>
Subject: Re: [NETFILTER]: H.323 helper: fix sequence extension parsing
Date: Tue, 23 May 2006 11:20:06 +0200 [thread overview]
Message-ID: <4472D3C6.6020305@trash.net> (raw)
In-Reply-To: <BAY109-DAV65DAA6039C77B3C71892DB39B0@phx.gbl>
Jing Min Zhao wrote:
> This is really a stupid bug. Thank you, Patrick.
>
>> Doesn't really fix the crash I was seeing, but does hide it away :)
>
>
> Can you please explain why? As I understand, it should've fixed
> the crash.
I think the reason why it make the crash go away is because the
packets contained a long stream of malformed unknown extensions.
When the son pointer went past the array of field_t elements it
hit the next array, which contained elements marked STOP, so it
aborted parsing and didn't got to the point where it would have
noticed the malformed extensions. By changing it not to run past
the array it aborted properly, hiding the real reason for the
crash (my other patch).
next prev parent reply other threads:[~2006-05-23 9:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 10:46 [NETFILTER]: H.323 helper: fix sequence extension parsing Patrick McHardy
2006-05-23 4:31 ` Jing Min Zhao
2006-05-23 9:20 ` Patrick McHardy [this message]
2006-05-23 15:28 ` Jing Min Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4472D3C6.6020305@trash.net \
--to=kaber@trash.net \
--cc=netfilter-devel@lists.netfilter.org \
--cc=zhaojingmin@hotmail.com \
--cc=zhaojingmin@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.