Re: [RFC, NETFILTER]: amanda helper: convert to textsearch infrastructure

[Pablo Neira Ayuso <pablo@netfilter.org>]

Pablo Neira Ayuso wrote:
> Patrick McHardy wrote:
>  -        *tmp = '\0';
>> +    memset(&ts, 0, sizeof(ts));
>> +    stop = skb_find_text(*pskb, start, (*pskb)->len,
>> +                 search[SEARCH_NEWLINE].ts, &ts);
> 
> Better use strstr here: the textsearch infrastructure implements 
> algorithms only introduce trade off for patterns longer than one byte. 
> So, in this case, the infrastructure can not help in any way.

Please, forget this comment, strstr is not fragment-aware.

-- 
The dawn of the fourth age of Linux firewalling is coming; a time of 
great struggle and heroic deeds -- J.Kadlecsik got inspired by J.Morris