All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Jens.Osterkamp@de.ibm.com
Cc: netdev@vger.kernel.org, arndb@de.ibm.com, utz.bacher@de.ibm.com
Subject: Re: [patch 1/2] spidernet: enable support for bcm5461 ethernet phy
Date: Wed, 24 May 2006 01:29:24 -0400	[thread overview]
Message-ID: <4473EF34.7050007@pobox.com> (raw)
In-Reply-To: <200605041159.41470.Jens.Osterkamp@de.ibm.com>

Jens Osterkamp wrote:
> From: Jens Osterkamp <Jens.Osterkamp@de.ibm.com>
> 
> A newer board revision changed the type of ethernet phy.
> Moreover, this generalizes the way that a phy gets switched
> into fiber mode when autodetection is not available.
> 
> Signed-off-by: Jens Osterkamp <Jens.Osterkamp@de.ibm.com>
> Signed-off-by: Arnd Bergmann <arnd.bergmann@de.ibm.com>
> 
> ---
> Index: linus-2.6/drivers/net/sungem_phy.c
> ===================================================================
> --- linus-2.6.orig/drivers/net/sungem_phy.c
> +++ linus-2.6/drivers/net/sungem_phy.c
> @@ -329,6 +329,30 @@ static int bcm5421_init(struct mii_phy* 
>  	return 0;
>  }
>  
> +static int bcm5421_enable_fiber(struct mii_phy* phy)
> +{
> +	/* enable fiber mode */
> +	phy_write(phy, MII_NCONFIG, 0x9020);
> +	/* LEDs active in both modes, autosense prio = fiber */
> +	phy_write(phy, MII_NCONFIG, 0x945f);
> +
> +	/* switch off fibre autoneg */
> +	phy_write(phy, MII_NCONFIG, 0xfc01);
> +	phy_write(phy, 0x0b, 0x0004);
> +
> +	return 0;
> +}
> +
> +static int bcm5461_enable_fiber(struct mii_phy* phy)
> +{
> +        phy_write(phy, MII_NCONFIG, 0xfc0c);
> +        phy_write(phy, MII_BMCR, 0x4140);
> +        phy_write(phy, MII_NCONFIG, 0xfc0b);
> +	phy_write(phy, MII_BMCR, 0x0140);

NAK, failed to apply.  Also, the whitespace above is borked.

	Jeff




  reply	other threads:[~2006-05-24  5:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20060504155034.486042000@>
2006-05-04  9:59 ` [patch 1/2] spidernet: enable support for bcm5461 ethernet phy Jens Osterkamp
2006-05-24  5:29   ` Jeff Garzik [this message]
2006-05-24 21:23     ` Jens Osterkamp
2006-05-04  9:59 ` [patch 2/2] spidernet: introduce new setting Jens Osterkamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4473EF34.7050007@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=Jens.Osterkamp@de.ibm.com \
    --cc=arndb@de.ibm.com \
    --cc=netdev@vger.kernel.org \
    --cc=utz.bacher@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.