From: Jeff Garzik <jgarzik@pobox.com>
To: Gary Zambrano <zambrano@broadcom.com>
Cc: netdev@vger.kernel.org
Subject: Re: [resend PATCH 1/1] b44: fix ethool link settings support
Date: Wed, 24 May 2006 02:41:18 -0400 [thread overview]
Message-ID: <4474000E.6070804@pobox.com> (raw)
In-Reply-To: <1146065509.28067.52.camel@dhcp-10-7-81-7.broadcom.com>
Gary Zambrano wrote:
> + if (cmd->advertising & ADVERTISE_ALL) {
> + if (cmd->advertising & ADVERTISE_10HALF)
> + bp->flags |= B44_FLAG_ADV_10HALF;
> + if (cmd->advertising & ADVERTISE_10FULL)
> + bp->flags |= B44_FLAG_ADV_10FULL;
> + if (cmd->advertising & ADVERTISE_100HALF)
> + bp->flags |= B44_FLAG_ADV_100HALF;
> + if (cmd->advertising & ADVERTISE_100FULL)
> + bp->flags |= B44_FLAG_ADV_100FULL;
> + } else {
> + bp->flags |= (B44_FLAG_ADV_10HALF |
> + B44_FLAG_ADV_10FULL |
> + B44_FLAG_ADV_100HALF |
> + B44_FLAG_ADV_100FULL);
> + }
The logic above is backwards. I presume the first test should be
if (!(cmd->advertising & ADVERTISE_ALL))
The rest looks OK.
Jeff
next prev parent reply other threads:[~2006-05-24 6:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-26 15:31 [resend PATCH 1/1] b44: fix ethool link settings support Gary Zambrano
2006-05-24 6:41 ` Jeff Garzik [this message]
2006-05-24 10:21 ` Gary Zambrano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4474000E.6070804@pobox.com \
--to=jgarzik@pobox.com \
--cc=netdev@vger.kernel.org \
--cc=zambrano@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.