From: "Björn Engelmann" <BjEngelmann@gmx.de>
To: Junio C Hamano <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] tagsize < 8kb restriction
Date: Wed, 24 May 2006 21:16:26 +0200 [thread overview]
Message-ID: <4474B10A.1020704@gmx.de> (raw)
In-Reply-To: <7vzmh81gfa.fsf@assigned-by-dhcp.cox.net>
>> 2.) Searching for a way to add objects to the database I spent quite a
>> while to find the right command. Don't you think it would be much more
>> intuitive having an
>>
>> git-create-object [-t <type>] [-n] [-f] [-z] [--stdin] <file> [-r
>> <ref-name>]
>>
>> command for creating any type of object (-t blob as default).
>>
>
> No, I do not think we would want to make it too easy and relaxed
> to create arbitrary object-looking thing. Each type have
> defined format and semantics, and creation of an object of each
> type should be validated. I do not want to encourage bypassing
> it by introducing such a backdoor. The backdoor is easy to
> write, but I suspect it would actively harm us, instead of
> helping us, by encouraging "let's build a custom type of object,
> we do not care if other people would not understand it"
> mentality.
>
Well, this is exactly what you have now in
git-hash-object -w -t foo
That is why I said, all input should be validated by default. All I
proposed was
a) unify the tools in order to have less duplicate code (git-mktag,
git-mktree & git-hash-object do merely the same except for the
validating part)
b) remove the possibility to introduce unchecked objects of arbitrary
type (or only allow it with the -f = "force, use with caution"-option)
maybe I should have written "blob, tag, tree or commit" instead of
"arbitrary". I did not mean really arbitrary like it is implemented
right now in git-hash-object.
Bj
next prev parent reply other threads:[~2006-05-24 19:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-22 14:48 [PATCH 0/2] tagsize < 8kb restriction Björn Engelmann
2006-05-22 19:18 ` Junio C Hamano
2006-05-22 23:12 ` Sean
2006-05-22 23:12 ` Sean
2006-05-23 0:02 ` Linus Torvalds
2006-05-23 9:59 ` Sean
2006-05-23 9:59 ` Sean
2006-05-23 20:40 ` Björn Engelmann
2006-05-23 23:15 ` Junio C Hamano
2006-05-24 19:16 ` Björn Engelmann [this message]
2006-05-24 19:39 ` Junio C Hamano
2006-05-25 11:53 ` Björn Engelmann
2006-05-25 20:03 ` Junio C Hamano
2006-05-23 23:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4474B10A.1020704@gmx.de \
--to=bjengelmann@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.