All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mathieu Ropert <mro@adviseo.fr>
To: Ian Pratt <m+Ian.Pratt@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [RESEND] Question about recursive mappings
Date: Wed, 24 May 2006 22:12:06 +0200	[thread overview]
Message-ID: <4474BE16.8060407@adviseo.fr> (raw)
In-Reply-To: <A95E2296287EAD4EB592B5DEEFCE0E9D4BA818@liverpoolst.ad.cl.cam.ac.uk>

Ian Pratt wrote:

>>About the possible fix, won't something like trying a
>>get_linear_pagetable() at all level works? Will it cause too 
>>much overhead?
>>Generally speaking, is allowing a R/O mapping of another 
>>table the domain own (whichever level it is) safe? At first 
>>thought, i don't see any way of exploiting it.
>>    
>>
>
>Yes, it's safe, you just need to get the 'general' ref count right,
>which as I recall, depends on whether the page you're mapping is in the
>same page table, or a foreign page table. The va back pointer means that
>there is a unique 'normal' place in each pagetable where a given page
>can be mapped, so you can easily inspect (via xen's linear mapping) to
>see whether the page belongs to the current pagetable or not.
>
>One thing we do have to watch out for is when we introduce super page
>mappings, as you have to be careful about using linear page tables in
>this context -- the x86 pagetable format doesn't allow you to generate a
>trap if a linear mapping attempts to misuse a superpage. That's not your
>worry right now :-) 
>
>Ian
>  
>
Ok, i've done a little patch which seems to resolve the issue on my test 
setup. Basically, i've modified get_linear_pagetable(), added a level 
parameter and call it for each level but level 1.
I need to do a little more test before i post the patch. As tomorrow is 
a national day, it should be ready friday.

Mathieu

  reply	other threads:[~2006-05-24 20:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-24  9:34 [RESEND] Question about recursive mappings Ian Pratt
2006-05-24 20:12 ` Mathieu Ropert [this message]
2006-05-24 20:16   ` Keir Fraser
2006-05-26  9:27     ` Mathieu Ropert
2006-05-29 11:43     ` Mathieu Ropert
  -- strict thread matches above, loose matches on Subject: below --
2006-05-23  9:41 Ian Pratt
2006-05-23  9:52 ` Keir Fraser
2006-05-23 12:22   ` Mathieu Ropert
2006-07-27 22:14   ` Bruce Rogers
2006-05-22  9:15 Mathieu Ropert
2006-05-22 15:18 ` Mathieu Ropert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4474BE16.8060407@adviseo.fr \
    --to=mro@adviseo.fr \
    --cc=m+Ian.Pratt@cl.cam.ac.uk \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.