From: Jiri Slaby <jirislaby@gmail.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Jeff Garzik <jeff@garzik.org>, Greg KH <gregkh@suse.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pci@atrey.karlin.mff.cuni.cz, stevel@mvista.com
Subject: Re: [PATCH 3/3] pci: gt96100eth use pci probing
Date: Thu, 25 May 2006 22:35:15 +0159 [thread overview]
Message-ID: <4476151A.4010404@gmail.com> (raw)
In-Reply-To: <20060525104147.GB3822@linux-mips.org>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Ralf Baechle napsal(a):
> On Wed, May 24, 2006 at 08:52:49PM -0400, Jeff Garzik wrote:
>
>> Jiri Slaby wrote:
>>> gt96100eth use pci probing
>>>
>>> Convert pci_find_device to pci probing. Use dev_* macros for printing.
>>>
>>> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
>
> The GT-96100 is not a PCI device but a system controller. The driver
> just checkes for the PCI ID to ensure it is not by accident being loaded
> on the wrong type of system. Which of course is suspect. If anything it
> should become a platform device.
Ooops. Ok, do you all agree to just remove pci_find_device() and add
pci_get_device() + pci_dev_put()? (And maybe next patch with dev_* macros).
regards,
- --
Jiri Slaby www.fi.muni.cz/~xslaby
\_.-^-._ jirislaby@gmail.com _.-^-._/
B67499670407CE62ACC8 22A032CC55C339D47A7E
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFEdhUaMsxVwznUen4RAllLAJsEs5QVVkHojpljkShQRu28p53n6wCgsCkA
/SuFkkLFIsC7ToR6FeGGhAE=
=akyh
-----END PGP SIGNATURE-----
prev parent reply other threads:[~2006-05-25 20:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060525003151.598EAC7C19@atrey.karlin.mff.cuni.cz>
2006-05-25 0:52 ` [PATCH 3/3] pci: gt96100eth use pci probing Jeff Garzik
2006-05-25 10:13 ` Jiri Slaby
2006-05-25 10:17 ` Jiri Slaby
2006-05-25 10:20 ` Jeff Garzik
2006-05-25 10:35 ` Jiri Slaby
2006-05-25 10:27 ` Jeff Garzik
2006-05-25 10:32 ` Jiri Slaby
2006-05-25 10:35 ` Jeff Garzik
2006-05-25 10:31 ` Jiri Slaby
2006-05-25 10:41 ` Ralf Baechle
2006-05-25 20:36 ` Jiri Slaby [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4476151A.4010404@gmail.com \
--to=jirislaby@gmail.com \
--cc=gregkh@suse.de \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=ralf@linux-mips.org \
--cc=stevel@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.