All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre Ossman <ossman@cendio.se>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] Allow ioplugins to override snd_pcm_delay()
Date: Fri, 26 May 2006 14:31:13 +0200	[thread overview]
Message-ID: <4476F511.4090705@cendio.se> (raw)
In-Reply-To: <s5hk689q8h5.wl%tiwai@suse.de>


[-- Attachment #1.1: Type: text/plain, Size: 846 bytes --]

Takashi Iwai wrote:
> 
> The change is OK, but please remind that the API has been already
> public, so we need to keep the compatibility as much as possible.
> This addition will break the binary compatibility.
> 
> First, we need the increase of version number
> (SND_PCM_IOPLUG_VERSION) if we modify API.  If the version of the
> object is older, either reject or allow it as compatible.
> 
> One way to keep it binary-compatible is to append the new method to
> the end of the callback table, and check the version before accessing
> the new method (and handle as NULL for older version).
> 
> Could you rewrite the patch in that manner?
> 

No problem. I'll have it fixed later this afternoon.

-- 
Rgds
Pierre Ossman                Telephone: +46-13-21 46 00
Cendio AB                    Web: http://www.cendio.com


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]



[-- Attachment #3: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

  reply	other threads:[~2006-05-26 12:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-26  9:38 [PATCH] Allow ioplugins to override snd_pcm_delay() Pierre Ossman
2006-05-26 12:24 ` Takashi Iwai
2006-05-26 12:31   ` Pierre Ossman [this message]
2006-05-26 12:35   ` Pierre Ossman
2006-05-26 12:41     ` Takashi Iwai
2006-05-26 12:41 ` James Courtier-Dutton
2006-05-26 12:46   ` Pierre Ossman
  -- strict thread matches above, loose matches on Subject: below --
2006-05-26 14:01 Pierre Ossman
2006-05-26 15:10 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4476F511.4090705@cendio.se \
    --to=ossman@cendio.se \
    --cc=alsa-devel@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.