From mboxrd@z Thu Jan  1 00:00:00 1970
From: Patrick McHardy <kaber@trash.net>
Subject: Re: [PATCH 1/4] TCPMSS: dont drop packets
Date: Fri, 26 May 2006 16:40:38 +0200
Message-ID: <44771366.90204@trash.net>
References: <20060524040441.111049000@snapgear.com>	<20060524040950.838105000@snapgear.com>
	<447486FA.8010206@trash.net> <4474EF6F.8060102@snapgear.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Cc: netfilter-devel@lists.netfilter.org
Return-path: <netfilter-devel-bounces@lists.netfilter.org>
To: Philip Craig <philipc@snapgear.com>
In-Reply-To: <4474EF6F.8060102@snapgear.com>
List-Unsubscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=unsubscribe>
List-Archive: </pipermail/netfilter-devel>
List-Post: <mailto:netfilter-devel@lists.netfilter.org>
List-Help: <mailto:netfilter-devel-request@lists.netfilter.org?subject=help>
List-Subscribe: <https://lists.netfilter.org/mailman/listinfo/netfilter-devel>,
	<mailto:netfilter-devel-request@lists.netfilter.org?subject=subscribe>
Sender: netfilter-devel-bounces@lists.netfilter.org
Errors-To: netfilter-devel-bounces@lists.netfilter.org
List-Id: netfilter-devel.vger.kernel.org

Philip Craig wrote:
> On 05/25/2006 02:16 AM, Patrick McHardy wrote:
> 
>>philipc@snapgear.com wrote:
>>
>>>The test case that caused problems was syn packet containing data.
>>
>>That seems to be an invalid testcase.
> 
> 
> I'm not sure if any stacks send or accept this in practice, but it is
> allowed by RFC 793, see second paragraph in section 3.4.  Please correct
> me if this is no longer valid.


No, you seem to be right. So I guess the entire check should be removed.
I'll look into this when finishing my other TCPMSS pathces.