All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
Cc: linux-arm-msm@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
	Stephen Boyd <sboyd@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	David Collins <david.collins@oss.qualcomm.com>,
	Subbaraman Narayanamurthy
	<subbaraman.narayanamurthy@oss.qualcomm.com>,
	Kamal Wadhwa <kamal.wadhwa@oss.qualcomm.com>,
	kernel@oss.qualcomm.com, linux-input@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] dt-bindings: input: Add binding for Qualcomm SPMI PMIC haptics
Date: Fri, 19 Jun 2026 06:18:56 +0200	[thread overview]
Message-ID: <44778bec-68c5-426d-bc05-b4013630b3ee@kernel.org> (raw)
In-Reply-To: <c7191868-d141-4095-b703-230237721f28@oss.qualcomm.com>

On 17/06/2026 13:02, Fenglin Wu wrote:
> 
> On 6/17/2026 6:35 PM, Krzysztof Kozlowski wrote:
>> On Tue, Jun 16, 2026 at 03:08:24AM -0700, Fenglin Wu wrote:
>>> ....
>>> +
>>> +  qcom,lra-period-us:
>>> +    description:
>>> +      LRA actuator initial resonance period in microseconds
>>> +      (1,000,000 / resonant_freq_hz).  Used to configure T_LRA-based play
>>> +      rates and the auto-resonance zero-crossing window.
>> This does not feel like static characteristic. Isn't period depending on
>> intensity of vibration you want to have? Why would that be fixed per
>> board?
> 
> This period is specifically used for playbacks that require 
> auto-resonance to be enabled, which I referred to as "T_LRA-based" and 
> "auto-resonance zero-crossing window." It plays a key role in the 
> "DIRECT_PLAY" mode, which produces a constant vibration effect. To 
> adjust the vibration intensity during this constant effect, the hardware 
> does it by scaling the peak voltage of the driver signals, rather than 
> changing the frequency.

But maybe changing frequency runtime still would be useful?

What does the frequency depend on? IOW, how do you choose the value here
- based on some motor-part characteristics?

Best regards,
Krzysztof

  reply	other threads:[~2026-06-19  4:19 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-16 10:08 [PATCH 0/4] input: misc: Add an initial driver for haptics inside Qcom PMIH010x PMIC Fenglin Wu
2026-06-16 10:08 ` [PATCH 1/4] dt-bindings: input: Add binding for Qualcomm SPMI PMIC haptics Fenglin Wu
2026-06-16 10:11   ` Konrad Dybcio
2026-06-16 10:18   ` sashiko-bot
2026-06-17 10:35   ` Krzysztof Kozlowski
2026-06-17 11:02     ` Fenglin Wu
2026-06-19  4:18       ` Krzysztof Kozlowski [this message]
2026-06-22  2:28         ` Fenglin Wu
2026-06-22 12:43           ` Krzysztof Kozlowski
2026-06-16 10:08 ` [PATCH 2/4] dt-bindings: mfd: qcom,spmi-pmic: Document haptics device Fenglin Wu
2026-06-16 10:17   ` sashiko-bot
2026-06-16 10:08 ` [PATCH 3/4] input: misc: Add Qualcomm SPMI PMIC haptics driver Fenglin Wu
2026-06-16 10:23   ` sashiko-bot
2026-06-16 10:25   ` Konrad Dybcio
2026-06-16 19:22     ` Dmitry Torokhov
2026-06-17  2:31     ` Fenglin Wu
2026-06-17  9:30       ` Konrad Dybcio
2026-06-17 10:12         ` Fenglin Wu
2026-06-16 14:37   ` Julian Braha
2026-06-16 10:08 ` [PATCH 4/4] arm64: dts: qcom: Add PMIH0108 haptics device node Fenglin Wu
2026-06-16 10:27   ` Konrad Dybcio
2026-06-17  1:30     ` Fenglin Wu
2026-06-17 10:42 ` [PATCH 0/4] input: misc: Add an initial driver for haptics inside Qcom PMIH010x PMIC Krzysztof Kozlowski
2026-06-24  7:20   ` Fenglin Wu
2026-06-24 10:05     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44778bec-68c5-426d-bc05-b4013630b3ee@kernel.org \
    --to=krzk@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=david.collins@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=fenglin.wu@oss.qualcomm.com \
    --cc=kamal.wadhwa@oss.qualcomm.com \
    --cc=kernel@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=subbaraman.narayanamurthy@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.