From: Michael Hordijk <mwh13@pitt.edu>
To: rmk+serial@arm.linux.org.uk
Cc: linux-serial@vger.kernel.org
Subject: [PATCH 2.6.16.18] 8250: Serial console enable Tx fix
Date: Fri, 26 May 2006 21:49:12 -0400 [thread overview]
Message-ID: <4477B018.1020101@pitt.edu> (raw)
Enabling the Tx interrupt from console_write on buggy UART (UART_BUG_TXEN)
breaks console transmit on said UART. Revert to previous UART_IER restore and
use serial8250_start_tx() to cause the transmit path to start and not hang.
Signed-off-by: Michael W. J. Hordijk <mwh13@pitt.edu>
--- linux-2.6.16.y/drivers/serial/8250.c.orig 2006-05-26 21:25:09.000116360 -0400
+++ linux-2.6.16.y/drivers/serial/8250.c 2006-05-26 21:26:54.000841539 -0400
@@ -2229,8 +2229,13 @@ serial8250_console_write(struct console
* and restore the IER
*/
wait_for_xmitr(up, BOTH_EMPTY);
- up->ier |= UART_IER_THRI;
- serial_out(up, UART_IER, ier | UART_IER_THRI);
+ serial_out(up, UART_IER, ier);
+
+ /*
+ * Start transmitting again in case it was clobbered racing between
+ * console and tty output.
+ */
+ serial8250_start_tx(up);
}
static int serial8250_console_setup(struct console *co, char *options)
next reply other threads:[~2006-05-27 1:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 1:49 Michael Hordijk [this message]
2006-06-02 16:48 ` [PATCH 2.6.16.18] 8250: Serial console enable Tx fix Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4477B018.1020101@pitt.edu \
--to=mwh13@pitt.edu \
--cc=linux-serial@vger.kernel.org \
--cc=rmk+serial@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.