From: Anne Thrax <foobarfoobarfoobar@gmail.com>
To: Catalin Marinas <catalin.marinas@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.17-rc5 1/7] Base support for kmemleak
Date: Sat, 27 May 2006 14:41:01 -0400 [thread overview]
Message-ID: <44789D3D.3020001@gmail.com> (raw)
In-Reply-To: <20060527122307.21451.84934.stgit@localhost.localdomain>
mm/memleak.c: In function `insert_pointer':
mm/memleak.c:216: warning: unused variable `i'
mm/memleak.c: At top level:
mm/memleak.c:586: warning: 'memleak_scan' defined but not used
> +/* Insert a pointer and its aliases into the pointer radix tree */
> +static inline void insert_pointer(unsigned long ptr, size_t size, int ref_count)
> +{
> + struct memleak_alias *alias;
> + struct hlist_node *elem;
> + struct memleak_pointer *pointer;
> + int err, i;
> +#ifdef CONFIG_FRAME_POINTER
> + void *frame;
> +#endif
If I'm not mistaken, you don't use 'i' outside of #ifdef CONFIG_FRAME_POINTER code.
> +/* Scan the memory and print the orphan pointers */
> +static void memleak_scan(void)
I don't think this is used anywhere in memleak.c besides
#ifdef CONFIG_DEBUG_FS code.
next prev parent reply other threads:[~2006-05-27 18:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-27 12:07 [PATCH 2.6.17-rc5 0/7] Kernel memory leak detector 0.2 Catalin Marinas
2006-05-27 12:23 ` [PATCH 2.6.17-rc5 1/7] Base support for kmemleak Catalin Marinas
2006-05-27 18:41 ` Anne Thrax [this message]
2006-05-27 20:20 ` Catalin Marinas
2006-05-27 12:23 ` [PATCH 2.6.17-rc5 2/7] Some documentation " Catalin Marinas
2006-05-27 12:23 ` [PATCH 2.6.17-rc5 3/7] Add the memory allocation/freeing hooks " Catalin Marinas
2006-05-27 12:23 ` [PATCH 2.6.17-rc5 4/7] Add kmemleak support for i386 Catalin Marinas
2006-05-27 12:23 ` [PATCH 2.6.17-rc5 5/7] Add kmemleak support for ARM Catalin Marinas
2006-05-27 12:23 ` [PATCH 2.6.17-rc5 6/7] Remove some of the kmemleak false positives Catalin Marinas
2006-05-27 12:24 ` [PATCH 2.6.17-rc5 7/7] Simple testing for kmemleak Catalin Marinas
-- strict thread matches above, loose matches on Subject: below --
2006-05-30 13:50 [PATCH 2.6.17-rc5 0/7] Kernel memory leak detector 0.3 Catalin Marinas
2006-05-30 14:07 ` [PATCH 2.6.17-rc5 1/7] Base support for kmemleak Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44789D3D.3020001@gmail.com \
--to=foobarfoobarfoobar@gmail.com \
--cc=catalin.marinas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.