Re: Resume stops working between 2.6.16 and 2.6.17-rc1 on Dell Inspiron 6000

[Mark Lord <lkml@rtr.ca>]

Paul Dickson wrote:
> On Sun, 28 May 2006 17:49:35 -0400, Mark Lord wrote:
> 
>> We've just now put out a one-liner patch to libata that fixes
>> resume on my own Inspiron, and for other machines as well.
>>
>> Does it fix the problem here too?  (copy of patch is attached)
> 
> Yes.  I compiled 2.6.17-rc5 without it and verified the problem occurs,
> then applied the patch and tried it again.  This time it worked.
> 
> I can suspend AND hibernate with the patch.

Good!  That patch is in the latest 2.6.17-rc*-git* now.

>I still get the BUG message on resuming that I reported in bugzilla
...
> BUG: sleeping function called from invalid context at mm/slab.c:2794
> in_atomic():0, irqs_disabled():1
>  <c01c971b> acpi_os_acquire_object+0xf/0x3c  <c0149c48> kmem_cache_alloc+0x27/0x7f
>  <c01c971b> acpi_os_acquire_object+0xf/0x3c  <c01df220> acpi_ut_allocate_object_desc_dbg+0xc/0x40
>  <c01df26d> acpi_ut_create_internal_object_dbg+0x19/0x70  <c01db3ef> acpi_rs_set_srs_method_data+0x40/0xc5
>  <c01e545d> acpi_pci_link_set+0x3e/0x16d  <c0149c96> kmem_cache_alloc+0x75/0x7f
>  <c01e5515> acpi_pci_link_set+0xf6/0x16d  <c01e55c0> irqrouter_resume+0x34/0x52
>  <c020eb77> __sysdev_resume+0x12/0x55  <c020ecd4> sysdev_resume+0x16/0x47
>  <c0213117> device_power_up+0x5/0xa  <c01293db> suspend_enter+0x32/0x3a
>  <c0129504> enter_state+0x121/0x13e  <c01295a2> state_store+0x81/0x94
>  <c0182fa9> sysfs_write_file+0xa3/0xc9  <c014d4c8> vfs_write+0xa2/0x136
>  <c014d9d2> sys_write+0x3b/0x64  <c0102ab3> syscall_call+0x7/0xb

Yup, pretty obvious bug in the acpi code.
Something probably needs to use GFP_ATOMIC there.