From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: mlord@pobox.com, albertcc@tw.ibm.com, alan@lxorguk.ukuu.org.uk,
axboe@suse.de, forrest.zhao@intel.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH 3/5] sata_sil: new interrupt handler
Date: Tue, 30 May 2006 13:21:20 +0900 [thread overview]
Message-ID: <447BC840.9000103@gmail.com> (raw)
In-Reply-To: <447BC6E9.104@pobox.com>
>> + if (!(bmdma2 & SIL_DMA_COMPLETE))
>> + continue;
>
> Is this bit asserted even on error?
>
Yeap.
>
>> + sil_host_intr(ap, bmdma2);
>> + handled = 1;
>> + }
>> +
>> + spin_unlock_irq(&host_set->lock);
>
> use spin_lock() and spin_unlock()
Of course. What was I on? :-(
--
tejun
next prev parent reply other threads:[~2006-05-30 4:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-29 6:34 [PATCHSET 02/03] prep LLDDs for hotplug support, take 3 Tejun Heo
2006-05-29 6:34 ` [PATCH 2/5] sata_sil: add new constants in preparation for new interrupt handler Tejun Heo
2006-05-30 4:14 ` Jeff Garzik
2006-05-29 6:34 ` [PATCH 5/5] sata_sil24: update sil24_hardreset() Tejun Heo
2006-05-30 4:16 ` Jeff Garzik
2006-05-29 6:34 ` [PATCH 4/5] sata_sil24: rename PORT_PRB to PORT_LRAM and add PORT_LRAM_SLOT_SZ Tejun Heo
2006-05-29 6:34 ` [PATCH 1/5] libata: export ata_hsm_move() Tejun Heo
2006-05-29 6:34 ` [PATCH 3/5] sata_sil: new interrupt handler Tejun Heo
2006-05-30 4:15 ` Jeff Garzik
2006-05-30 4:21 ` Tejun Heo [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-05-31 11:11 [PATCHSET 02/03] prep LLDDs for hotplug support, take 4 Tejun Heo
2006-05-31 11:11 ` [PATCH 3/5] sata_sil: new interrupt handler Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447BC840.9000103@gmail.com \
--to=htejun@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=albertcc@tw.ibm.com \
--cc=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mlord@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.