All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>
Cc: "zhao, forrest" <forrest.zhao@intel.com>,
	liml@rtr.ca, linux-ide@vger.kernel.org
Subject: Re: [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command
Date: Tue, 30 May 2006 00:41:32 -0400	[thread overview]
Message-ID: <447BCCFC.10908@garzik.org> (raw)
In-Reply-To: <447AB9FB.6020706@gmail.com>

Tejun Heo wrote:
> * I've renamed ata_hotplug_wq to ata_scsi_wq in hotplug patches.  I 
> think rescan can use this wq instead of creating its own.

I think we will use this workqueue even when SCSI is optional, so 
ata_scsi_wq may not be the best name, long term.  I ACK'd its inclusion 
of course, so not a big deal.


> * When snooping for SETFEATURES in ata_scsi_qc_complete(), why check 
> cdb[0] for ATA_16/12?  Isn't simply checking tf.command enough?

yes


> * There's a race window between ATA revalidation and SCSI rescan.  We 
> can plug this hole by deferring commands till rescan is complete.  But I 
> doubt it would be worth the trouble.

probably, we'll see...  :)

	Jeff



  parent reply	other threads:[~2006-05-30  4:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-25  9:02 [PATCH] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command zhao, forrest
2006-05-27  0:15 ` Jeff Garzik
2006-05-29  6:35   ` zhao, forrest
2006-05-29 11:29     ` Mark Lord
2006-05-29  9:08   ` Tejun Heo
2006-05-29  9:18     ` zhao, forrest
2006-05-29  9:46       ` Tejun Heo
2006-05-29  9:20     ` Jeff Garzik
2006-05-29  9:43       ` Tejun Heo
2006-05-30  3:57         ` Jeff Garzik
2006-05-30  4:41     ` Jeff Garzik [this message]
2006-05-30  4:50       ` Tejun Heo
2006-05-30  4:57         ` Jeff Garzik
2006-05-30  5:10           ` Tejun Heo
2006-05-30  5:08             ` zhao, forrest
2006-05-30  7:22               ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447BCCFC.10908@garzik.org \
    --to=jeff@garzik.org \
    --cc=forrest.zhao@intel.com \
    --cc=htejun@gmail.com \
    --cc=liml@rtr.ca \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.