All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick McHardy <kaber@trash.net>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@lists.netfilter.org, Eric Leblond <eric@inl.fr>
Subject: Re: [PATCH] Unconditionaly push mark to conntrack structure
Date: Wed, 31 May 2006 01:55:47 +0200	[thread overview]
Message-ID: <447CDB83.1090606@trash.net> (raw)
In-Reply-To: <447CD8AA.2040502@trash.net>

Patrick McHardy wrote:
> Eric Leblond wrote:
> 
>>This is needed in userspace as the mark can be used to select 
>>efficiently a subset of the conntrack events to work on.
> 
> 
> I'm a bit reluctant to special case mark, but mostly because I wonder
> whether we shouldn't just behave like all other networking subsystems
> and send update messages containing the entire new state. If you look
> at the optional information:
> 
> - status bits are only 4 byte.
> - timeout is currently transmitted for every packet anyway - its better
>   to just reduce the event rate (we even had a patch for this for ages)

Actually this isn't true, I just noticed we never send timeout update
notifications except for the first packet (which means we have tons
of unnecessary notifier chain calls). I think this isn't really
intended and was done to work around the high timeout event generation
rate. Pablo, do you more about this?

  reply	other threads:[~2006-05-30 23:55 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-19  8:45 [PATCH] Unconditionaly push mark to conntrack structure Eric Leblond
2006-05-30 23:43 ` Patrick McHardy
2006-05-30 23:55   ` Patrick McHardy [this message]
2006-05-31  0:26     ` Patrick McHardy
2006-05-31  0:35       ` Pablo Neira Ayuso
2006-05-31  1:01         ` Patrick McHardy
2006-06-06 11:35           ` Pablo Neira Ayuso
2006-06-08  7:25             ` Patrick McHardy
2006-06-11 22:00               ` Pablo Neira Ayuso
2006-06-06 17:27           ` Pablo Neira Ayuso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447CDB83.1090606@trash.net \
    --to=kaber@trash.net \
    --cc=eric@inl.fr \
    --cc=netfilter-devel@lists.netfilter.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.