All of lore.kernel.org
 help / color / mirror / Atom feed
From: lamikr <lamikr@cc.jyu.fi>
To: OMAP <Linux-omap-open-source@linux.omap.com>
Subject: [PATCH] omap-alsa, force the dma to receive irqs on all omap15xx based devices.
Date: Wed, 31 May 2006 03:23:36 +0300	[thread overview]
Message-ID: <447CE208.3060400@cc.jyu.fi> (raw)

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

Hi

According to tests made by James Selvam, this patch is also needed in
other omap1510 based devices that with iPAQ h6300.
I suggest adding this patch unless someone finds out a bug in upper
level explaining the need for stopping the dma in every round to be able
to get the irq.

Mika

[-- Attachment #2: omap-alsa-force-the-dma-to-receive-irqs-on-all-omap15xx-based-devices.txt --]
[-- Type: text/plain, Size: 1420 bytes --]

>From nobody Mon Sep 17 00:00:00 2001
From: Mika Laitio <lamikr@cc.jyu.fi>
Date: Wed May 31 02:08:16 2006 +0300
Subject: [PATCH] omap-alsa, force the dma to receive irqs on all omap15xx based devices.

Signed-off-by: lamikr <lamikr@cc.jyu.fi>


---

 sound/arm/omap/omap-alsa.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

8dcab62d5f3e6cb4ba4f8d1b677d94694036e4ae
diff --git a/sound/arm/omap/omap-alsa.c b/sound/arm/omap/omap-alsa.c
index 328003b..5a68471 100644
--- a/sound/arm/omap/omap-alsa.c
+++ b/sound/arm/omap/omap-alsa.c
@@ -190,7 +190,7 @@ static void audio_process_dma(struct aud
 	unsigned int dma_size;
 	unsigned int offset;
 	int ret;
-#ifdef CONFIG_MACH_OMAP_H6300
+#ifdef CONFIG_ARCH_OMAP15XX
 	unsigned long flags;
 #endif
 	
@@ -200,7 +200,13 @@ static void audio_process_dma(struct aud
 		dma_size = frames_to_bytes(runtime, runtime->period_size);
 		offset = dma_size * s->period;
 		snd_assert(dma_size <= DMA_BUF_SIZE,);
-#ifdef CONFIG_MACH_OMAP_H6300
+#ifdef CONFIG_ARCH_OMAP15XX
+		/*
+		 * On omap1510 based devices, we need to call the stop_dma
+		 * before calling the start_dma or we will not receive the
+		 * irq from DMA after the first transfered/played buffer.
+		 * (invocation of callback_omap_alsa_sound_dma() method).
+		 */
 		spin_lock_irqsave(&s->dma_lock, flags);
 		omap_stop_alsa_sound_dma(s);
 		spin_unlock_irqrestore(&s->dma_lock, flags);
-- 
1.2.2


[-- Attachment #3: Type: text/plain, Size: 0 bytes --]



             reply	other threads:[~2006-05-31  0:23 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-31  0:23 lamikr [this message]
2006-05-31 10:54 ` [PATCH] omap-alsa, force the dma to receive irqs on all omap15xx based devices Jonathan McDowell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447CE208.3060400@cc.jyu.fi \
    --to=lamikr@cc.jyu.fi \
    --cc=Linux-omap-open-source@linux.omap.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.