Re: [PATCH v2] Snoop SET FEATURES - WRITE CACHE ENABLE/DISABLE command

[Tejun Heo <htejun@gmail.com>]

Tejun Heo wrote:
>> +	    ((qc->tf.feature == SETFEATURES_WC_ON) ||
>> +	     (qc->tf.feature == SETFEATURES_WC_OFF))) {
>> +		qc->ap->eh_info.action = ATA_EH_REVALIDATE;
> 
> Please do action |= ATA_EH_REVALIDATE.  Also, above schedules
> revalidation for both devices for a PATA port.  Currently, there is no
> way to specify which device is offending from qc completion path.  I'll
> submit a patch to allow it.  After the patch, please add
> qc->ap->eh_info.dev = qc->dev such that only the affected device is
> revalidated.

Please forget about the qc->ap->eh_info.dev = qc->dev stuff.  At the
second thought, it doesn't seem worth the trouble and seems safer as it
currently is.

-- 
tejun