From: "bibo,mao" <bibo.mao@intel.com>
To: greg@kroah.com
Cc: linux-kernel@vger.kernel.org
Subject: [Cleanup] cleanup unused variable about msi driver
Date: Wed, 31 May 2006 18:17:33 +0800 [thread overview]
Message-ID: <447D6D3D.5020608@intel.com> (raw)
In IA64 platform, msi driver does not use irq_vector variable, and in
x86 platform LAST_DEVICE_VECTOR should one before FIRST_SYSTEM_VECTOR,
this patch modify this.
Signed-off-by: bibo, mao<bibo.mao@intel.com>
Thanks
Bibo,mao
---
diff -Nruap 2.6.17-rc5-mm1.org/drivers/pci/msi.c 2.6.17-rc5-mm1/drivers/pci/msi.c
--- 2.6.17-rc5-mm1.org/drivers/pci/msi.c 2006-05-31 15:10:51.000000000 +0800
+++ 2.6.17-rc5-mm1/drivers/pci/msi.c 2006-05-31 15:21:38.000000000 +0800
@@ -35,7 +35,6 @@ static int nr_msix_devices;
#ifndef CONFIG_X86_IO_APIC
int vector_irq[NR_VECTORS] = { [0 ... NR_VECTORS - 1] = -1};
-u8 irq_vector[NR_IRQ_VECTORS];
#endif
static struct msi_ops *msi_ops;
@@ -383,10 +382,6 @@ static int msi_init(void)
return status;
}
-#ifndef CONFIG_X86_IO_APIC
- irq_vector[0] = FIRST_DEVICE_VECTOR;
-#endif
-
if (last_alloc_vector < 0) {
pci_msi_enable = 0;
printk(KERN_WARNING "PCI: No interrupt vectors available for MSI\n");
diff -Nruap 2.6.17-rc5-mm1.org/include/asm-i386/msi.h 2.6.17-rc5-mm1/include/asm-i386/msi.h
--- 2.6.17-rc5-mm1.org/include/asm-i386/msi.h 2006-05-31 15:10:51.000000000 +0800
+++ 2.6.17-rc5-mm1/include/asm-i386/msi.h 2006-05-31 15:22:10.000000000 +0800
@@ -9,7 +9,7 @@
#include <asm/desc.h>
#include <mach_apic.h>
-#define LAST_DEVICE_VECTOR 232
+#define LAST_DEVICE_VECTOR (FIRST_SYSTEM_VECTOR - 1)
#define MSI_TARGET_CPU_SHIFT 12
extern struct msi_ops msi_apic_ops;
diff -Nruap 2.6.17-rc5-mm1.org/include/asm-x86_64/msi.h 2.6.17-rc5-mm1/include/asm-x86_64/msi.h
--- 2.6.17-rc5-mm1.org/include/asm-x86_64/msi.h 2006-05-31 15:10:50.000000000 +0800
+++ 2.6.17-rc5-mm1/include/asm-x86_64/msi.h 2006-05-31 15:22:28.000000000 +0800
@@ -10,7 +10,7 @@
#include <asm/mach_apic.h>
#include <asm/smp.h>
-#define LAST_DEVICE_VECTOR 232
+#define LAST_DEVICE_VECTOR (FIRST_SYSTEM_VECTOR - 1)
#define MSI_TARGET_CPU_SHIFT 12
extern struct msi_ops msi_apic_ops;
reply other threads:[~2006-05-31 10:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447D6D3D.5020608@intel.com \
--to=bibo.mao@intel.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.