From: Andy Whitcroft <apw@shadowen.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
Chad Reese <creese@caviumnetworks.com>
Subject: Re: [PATCH] Sparsemem build fix.
Date: Wed, 31 May 2006 17:57:41 +0100 [thread overview]
Message-ID: <447DCB05.5040002@shadowen.org> (raw)
In-Reply-To: <20060531132750.GA9504@linux-mips.org>
Ralf Baechle wrote:
> <linux/mmzone.h> uses PAGE_SIZE, PAGE_SHIFT from <asm/page.h> without
> including that header itself. For some sparsemem configurations this
> may result in build errors like:
>
> CC init/initramfs.o
> In file included from include/linux/gfp.h:4,
> from include/linux/slab.h:15,
> from include/linux/percpu.h:4,
> from include/linux/rcupdate.h:41,
> from include/linux/dcache.h:10,
> from include/linux/fs.h:226,
> from init/initramfs.c:2:
> include/linux/mmzone.h:498:22: warning: "PAGE_SHIFT" is not defined
> In file included from include/linux/gfp.h:4,
> from include/linux/slab.h:15,
> from include/linux/percpu.h:4,
> from include/linux/rcupdate.h:41,
> from include/linux/dcache.h:10,
> from include/linux/fs.h:226,
> from init/initramfs.c:2:
> include/linux/mmzone.h:526: error: `PAGE_SIZE' undeclared here (not in a function)
> include/linux/mmzone.h: In function `__pfn_to_section':
> include/linux/mmzone.h:573: error: `PAGE_SHIFT' undeclared (first use in this function)
> include/linux/mmzone.h:573: error: (Each undeclared identifier is reported only once
> include/linux/mmzone.h:573: error: for each function it appears in.)
> include/linux/mmzone.h: In function `pfn_valid':
> include/linux/mmzone.h:578: error: `PAGE_SHIFT' undeclared (first use in this function)
> make[1]: *** [init/initramfs.o] Error 1
> make: *** [init] Error 2
>
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 3674035..2d83371 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -15,6 +15,7 @@ #include <linux/init.h>
> #include <linux/seqlock.h>
> #include <linux/nodemask.h>
> #include <asm/atomic.h>
> +#include <asm/page.h>
>
> /* Free memory management - zoned buddy allocator. */
> #ifndef CONFIG_FORCE_MAX_ZONEORDER
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
Seems completely reasonable.
-apw
prev parent reply other threads:[~2006-05-31 16:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 13:27 [PATCH] Sparsemem build fix Ralf Baechle
2006-05-31 16:57 ` Andy Whitcroft [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447DCB05.5040002@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@osdl.org \
--cc=creese@caviumnetworks.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ralf@linux-mips.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.