Re: 2.6.17-rc5-mm1 - output of lock validator

[Arjan van de Ven <arjan@linux.intel.com>]

Andrew Morton wrote:
> Arjan van de Ven <arjan@linux.intel.com> wrote:
>> Andrew Morton wrote:
>>> On Wed, 31 May 2006 16:28:59 +0200
>>> Arjan van de Ven <arjan@linux.intel.com> wrote:
>>>
>>>> --- linux-2.6.17-rc5-mm1.5.orig/drivers/net/8390.c
>>>> +++ linux-2.6.17-rc5-mm1.5/drivers/net/8390.c
>>>> @@ -299,7 +299,7 @@ static int ei_start_xmit(struct sk_buff 
>>>>  	 
>>>>  	disable_irq_nosync(dev->irq);
>>>>  	
>>>> -	spin_lock(&ei_local->page_lock);
>>>> +	spin_lock_irqsave(&ei_local->page_lock, flags);
>>> Again, notabug - we did disable_irq().
>> but does disable_irq() work in the light of that irqpoll stuff?
>>
> 
> Don't have a clue what you're referring to, sorry.

misrouted_irq() in kernel/irq/spurious.c
afaics that calls all handlers registered to the system regardless of what
irq number they are registered for.....

which breaks the disable_irq() locking trick... because your irq handler now
gets called anyway!