From: Rob Gardner <rob.gardner@hp.com>
To: George Dunlap <dunlapg@umich.edu>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] Make xentrace hypercall a bit more sane
Date: Thu, 01 Jun 2006 14:24:33 -0600 [thread overview]
Message-ID: <447F4D01.1080700@hp.com> (raw)
In-Reply-To: <de76405a0606011317qe1fed70u1eb52e6046d32246@mail.gmail.com>
George Dunlap wrote:
> xentrace, setsize and the hypervisor don't seem to be on the same
> page. If tracing is not enabled, the hypercall will only allow
> TBUF_SET_SIZE and TBUF_ENABLE. However, set_size calls TBUF_GET_INFO,
> and xentrace wants to call TBUF_SET_EVT_MASK and TBUF_SET_CPU_MASK
> before calling TBUF_ENABLE.
>
> I don't see any reason not to call SET_*_MASK and GET_INFO if tracing
> is not enabled. If the buffer hasn't been allocated yet, GET_INFO
> should just return something invalid in the mfn field. Anyone calling
> should check this value.
>
Sounds benign enough. I never liked the behavior of disallowing the
get_info call.
Rob
prev parent reply other threads:[~2006-06-01 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 20:17 [PATCH] Make xentrace hypercall a bit more sane George Dunlap
2006-06-01 20:24 ` Rob Gardner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=447F4D01.1080700@hp.com \
--to=rob.gardner@hp.com \
--cc=dunlapg@umich.edu \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.