All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "zhao, forrest" <forrest.zhao@intel.com>
Cc: jeff@garzik.org, axboe@suse.de, htejun@gmail.com,
	jeremy@goop.org, lkml@rtr.ca, linux-ide@vger.kernel.org
Subject: Re: [PATCH 6/6] Implement the AHCI suspend/resume
Date: Fri, 02 Jun 2006 10:21:34 +0200	[thread overview]
Message-ID: <447FF50E.4060609@suse.de> (raw)
In-Reply-To: <1149234379.13451.59.camel@forrest26.sh.intel.com>

zhao, forrest wrote:
> This patch implements the AHCI suspend/resume.
> It puts the port suspend/resume operations in 
> ahci_pci_device_suspend/resume(), which is in conformance with
> Jeff's idea of host<->bus<->device suspend/resume sequence.
> 
> 
> Signed-off-by: Forrest Zhao <forrest.zhao@intel.com>
> 
There is one quirky bit in here: we have to enable interrupts for the
_adapter_ after all _devices_ have been re-initialized.
This breaks the host<->bus<->device initialization sequence.
Is there any chance libata can add some hooks for that sort of thing?
The current approach (using a device map and run the host initialisation
after the last device is done) is a bit hackish.
I'd rather like to see the upper layers being able to deal with such
devices. But until then:

Signed-off-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

  reply	other threads:[~2006-06-02  8:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-02  7:46 [PATCH 6/6] Implement the AHCI suspend/resume zhao, forrest
2006-06-02  8:21 ` Hannes Reinecke [this message]
2006-06-02  8:34   ` Tejun Heo
2006-06-03 13:35 ` Tejun Heo
2006-06-05  5:05   ` zhao, forrest
  -- strict thread matches above, loose matches on Subject: below --
2006-06-06 10:17 zhao, forrest
2006-06-29  8:21 zhao, forrest
2006-07-10  3:35 zhao, forrest
2006-07-10  7:34 ` zhao, forrest
2006-07-10  7:34 zhao, forrest
2006-07-11  6:42 zhao, forrest
2006-07-13  5:39 zhao, forrest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=447FF50E.4060609@suse.de \
    --to=hare@suse.de \
    --cc=axboe@suse.de \
    --cc=forrest.zhao@intel.com \
    --cc=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=jeremy@goop.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=lkml@rtr.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.