Re: [PATCH 0/2] KVM: s390: Fix latent guest entry/exit bugs

[Janosch Frank <frankja@linux.ibm.com>]

On 7/8/25 11:27 AM, Andrew Donnellan wrote:
> In [0], the guest_{enter,exit}_irqoff() helpers were deprecated, in favour
> of guest_timing_{enter,exit}_irqoff() and
> guest_context_{enter,exit}_irqoff(). This was to fix a number of latent
> guest entry/exit bugs, relating to the enabling of interrupts during an
> RCU extended quiescent state, instrumentation code, and correct handling
> of lockdep and tracing.
> 
> However, while arm64, mips, riscv and x86 have been migrated to the new
> helpers, s390 hasn't been. There was an initial attempt at [1] to do this,
> but that didn't work for reasons discussed at [2].
> 
> Since then, Claudio Imbrenda has reworked much of the interrupt handling.
> Moving interrupt handling into vcpu_post_run() avoids the issues in [2],
> so we can now move to the new helpers.
> 
> I've rebased Mark's patches from [1]. kvm-unit-tests, the kvm selftests,
> and IBM's internal test suites pass under debug_defconfig.
> 
> These patches do introduce some overhead - in my testing, a few of the
> tests in the kvm-unit-tests exittime test suite appear 6-11% slower, but
> some noticeable overhead may be unavoidable (we introduce a new function
> call and the irq entry/exit paths change a bit).
> 

This series has been part of our CI runs for some while and hasn't 
caused issues.

Series:
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>