All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: luca.boccassi@gmail.com
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass MODULE_CFLAGS in Kbuild
Date: Wed, 11 Nov 2020 13:22:24 +0100	[thread overview]
Message-ID: <4480256.CgzZVRB0LV@thomas> (raw)
In-Reply-To: <20201111121626.156252-1-luca.boccassi@gmail.com>

11/11/2020 13:16, luca.boccassi@gmail.com:
> From: Luca Boccassi <bluca@debian.org>
> 
> With the legacy build system MODULE_CFLAGS can be set to pass compiler
> flags specific for the kernel modules builds.
> This is used currently by Ubuntu and Debian.
> Set ccflags-y in the Kbuild to achieve the same result with Meson, and
> to keep backward compatbility with older scripts.
> 
> Fixes regression in Ubuntu/Debian when the Kbuild is included in the
> DKMS source package, as DKMS will pick it up silently by default if
> present, causing the MODULE_CFLAGS to be ignored.
> 
> Fixes: a52f4574f798 ("igb_uio: build with meson")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: backported original commit instead of making a new one

Applied with original commit date,
and simpler explanation from the v1
because meson/make history is not relevant in this repo.



      reply	other threads:[~2020-11-11 12:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-28 18:15 [dpdk-dev] [PATCH dpdk-kmods] igb_uio: include MODULE_CFLAGS in Kbuild luca.boccassi
2020-10-29 20:58 ` Thomas Monjalon
2020-10-30 16:33   ` Luca Boccassi
2020-11-11 12:16 ` [dpdk-dev] [PATCH dpdk-kmods v2] igb_uio: pass " luca.boccassi
2020-11-11 12:22   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4480256.CgzZVRB0LV@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=luca.boccassi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.