From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH, resend] blkfront: ioctls/geometry, 2.6
Date: Fri, 02 Jun 2006 12:53:55 +0200 [thread overview]
Message-ID: <448034E3.76E4.0078.0@novell.com> (raw)
In-Reply-To: <5324398cd809a2cde429589727c53ee5@cl.cam.ac.uk>
>>> Keir Fraser <Keir.Fraser@cl.cam.ac.uk> 02.06.06 12:19 >>>
>
>On 2 Jun 2006, at 11:05, Jan Beulich wrote:
>
>> Add backing support for HDIO_GETGEO ioctl to blkfront.
>>
>> Inspired by an earlier patch from Charles Coffing.
>
>Does this have any effect? It looks to me as though HDIO_GETGEO is
>handled by block/ioctl.c:blkdev_ioctl(). I also note that *no* other
>blkdev drivers define their own HDIO_GETGEO handler. Shouldn't we just
>remove that case from our ioctl switch statement and define a 'getgeo'
>function hook?
But that is exactly what the patch does. It instead adds a getgeo function to vbd, which is what several other drivers
also have, and which is what backs blkdev_ioctl()'s handling of HDIO_GETGEO.
>Given that this patch can't have any effect, what drove you guys to
>implement it? :-)
We saw GrUB failing when used inside a domU.
Jan
next prev parent reply other threads:[~2006-06-02 10:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-02 10:05 [PATCH, resend] blkfront: ioctls/geometry, 2.6 Jan Beulich
2006-06-02 10:19 ` Keir Fraser
2006-06-02 10:53 ` Jan Beulich [this message]
2006-06-02 11:04 ` Keir Fraser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448034E3.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=Keir.Fraser@cl.cam.ac.uk \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.