All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpufreq-nforce2 divider
@ 2006-06-04 17:42 Sebastian Witt
  2006-06-04 23:42 ` Dave Jones
  0 siblings, 1 reply; 5+ messages in thread
From: Sebastian Witt @ 2006-06-04 17:42 UTC (permalink / raw)
  To: cpufreq

Patch against 2.6.16. Sets minimum PLL divider to 2. No negative impact when 
tested with two nForce2 based boards. (Updates also the (C) year)

Signed-off-by: Sebastian Witt <se.witt <at> gmx net>
---

--- linux-2.6.16-gentoo-r7.orig/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c 
2006-06-04 19:32:29.000000000 +0200
+++ linux-2.6.16-gentoo-r7/arch/i386/kernel/cpu/cpufreq/cpufreq-nforce2.c 
2006-06-04 19:32:42.000000000 +0200                     @@ -1,5 +1,5 @@
  /*
- * (C) 2004  Sebastian Witt <se.witt@gmx.net>
+ * (C) 2004-2006  Sebastian Witt <se.witt@gmx.net>
   *
   *  Licensed under the terms of the GNU GPL License version 2.
   *  Based upon reverse engineered information
@@ -90,7 +90,7 @@

         /* Try to calculate multiplier and divider up to 4 times */
         while (((mul == 0) || (div == 0)) && (tried <= 3)) {
-               for (xdiv = 1; xdiv <= 0x80; xdiv++)
+               for (xdiv = 2; xdiv <= 0x80; xdiv++)
                         for (xmul = 1; xmul <= 0xfe; xmul++)
                                 if (nforce2_calc_fsb(NFORCE2_PLL(xmul, xdiv)) ==
                                     fsb + tried) {

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] cpufreq-nforce2 divider
  2006-06-04 17:42 [PATCH] cpufreq-nforce2 divider Sebastian Witt
@ 2006-06-04 23:42 ` Dave Jones
  2006-06-05 19:18   ` Sebastian Witt
  0 siblings, 1 reply; 5+ messages in thread
From: Dave Jones @ 2006-06-04 23:42 UTC (permalink / raw)
  To: Sebastian Witt; +Cc: cpufreq

On Sun, Jun 04, 2006 at 07:42:16PM +0200, Sebastian Witt wrote:
 > Patch against 2.6.16. Sets minimum PLL divider to 2. No negative impact 
 > when tested with two nForce2 based boards

Ok, but for the sake of the changelog, can you explain why
this is a good thing ?

		Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] cpufreq-nforce2 divider
  2006-06-04 23:42 ` Dave Jones
@ 2006-06-05 19:18   ` Sebastian Witt
  2006-06-05 19:24     ` Dave Jones
       [not found]     ` <20060606214323.77785.qmail@web33604.mail.mud.yahoo.com>
  0 siblings, 2 replies; 5+ messages in thread
From: Sebastian Witt @ 2006-06-05 19:18 UTC (permalink / raw)
  To: Dave Jones; +Cc: cpufreq

Dave Jones wrote:
> 
> Ok, but for the sake of the changelog, can you explain why
> this is a good thing ?
> 

Alexander Choporov reported (06/01/06) that xdiv = 1 does not work on his Abit 
NF7S2. Although there shouldn't be much cases that lead to xdiv = 1.

Regards,
Sebastian

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] cpufreq-nforce2 divider
  2006-06-05 19:18   ` Sebastian Witt
@ 2006-06-05 19:24     ` Dave Jones
       [not found]     ` <20060606214323.77785.qmail@web33604.mail.mud.yahoo.com>
  1 sibling, 0 replies; 5+ messages in thread
From: Dave Jones @ 2006-06-05 19:24 UTC (permalink / raw)
  To: Sebastian Witt; +Cc: cpufreq

On Mon, Jun 05, 2006 at 09:18:57PM +0200, Sebastian Witt wrote:
 > Dave Jones wrote:
 > >
 > >Ok, but for the sake of the changelog, can you explain why
 > >this is a good thing ?
 > >
 > 
 > Alexander Choporov reported (06/01/06) that xdiv = 1 does not work on his 
 > Abit NF7S2. Although there shouldn't be much cases that lead to xdiv = 1.

Ok, I've applied this by hand as your patch was badly whitespace damaged
(Every tab had been converted to spaces in your diff)

Please make sure that doesn't happen for future diffs.

Thanks,

		Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: REMOVE ME FROM LIST!!!
       [not found]     ` <20060606214323.77785.qmail@web33604.mail.mud.yahoo.com>
@ 2006-06-06 23:26       ` Dave Jones
  0 siblings, 0 replies; 5+ messages in thread
From: Dave Jones @ 2006-06-06 23:26 UTC (permalink / raw)
  To: Pierre J Hood; +Cc: cpufreq

On Tue, Jun 06, 2006 at 02:43:23PM -0700, Pierre J Hood wrote:
 > I have emailed you before requesting REMOVAL from your list so I DONT RECIEVE ANY MORE EMAILS like the following FROM YOU!!!. 
 >   Please respect my wishes and remove me from your mailing list.

I've seen no such mails from you.
But at the bottom of every mail you're receiving is this footer :-

 > _______________________________________________
 > Cpufreq mailing list
 > Cpufreq@lists.linux.org.uk
 > http://lists.linux.org.uk/mailman/listinfo/cpufreq

From there you will be able to unsubscribe yourself, or get a reminder
of your list password if you don't have it.

		Dave

-- 
http://www.codemonkey.org.uk

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2006-06-06 23:26 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-04 17:42 [PATCH] cpufreq-nforce2 divider Sebastian Witt
2006-06-04 23:42 ` Dave Jones
2006-06-05 19:18   ` Sebastian Witt
2006-06-05 19:24     ` Dave Jones
     [not found]     ` <20060606214323.77785.qmail@web33604.mail.mud.yahoo.com>
2006-06-06 23:26       ` REMOVE ME FROM LIST!!! Dave Jones

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.