All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@gentoo.org>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-acpi@vger.kernel.org, joliveirinha@gmail.com,
	Stephen Hemminger <shemminger@osdl.org>
Subject: Re: Most interrupts are edge-triggered, non-APIC system
Date: Mon, 05 Jun 2006 20:56:10 +0100	[thread overview]
Message-ID: <44848C5A.8090409@gentoo.org> (raw)
In-Reply-To: <200606051243.23006.bjorn.helgaas@hp.com>

Bjorn Helgaas wrote:
> On Thursday 01 June 2006 15:04, Daniel Drake wrote:
>> João Oliveirinha reported a bug related to the sky2 network driver on 
>> the Gentoo bugzilla. Stephen Hemminger (sky2 author) kindly helped 
>> diagnose the issues, and he believes that one of the reasons why things 
>> are running sub-optimally is because the interrupt assigned to sky2 is 
>> edge-triggered (NAPI requires things to be level-triggered).
> 
> I'm not convinced that the sky2 interrupt is edge-triggered.

Thanks for the explanation, that makes sense. Stephen, you might be 
interested in this: (don't worry, nothing is broken!)

> The "ELCR" line:
>   ACPI: setting ELCR to 0200 (from 0c20)
> only shows the ELCR state early during boot when we're setting
> up the ACPI SCI interrupt.
> 
> Interrupts can also be set to level-triggered mode later, when
> the driver claims the device.  This in the acpi_register_gsi() ->
> eisa_set_level_irq() path and prints a different message.
> 
> Attachment http://bugs.gentoo.org/attachment.cgi?id=85619&action=view
> shows that sky2 should be on IRQ11, and it should be level-triggered:
> 
>   ACPI: PCI Interrupt Link [LNKA] enabled at IRQ 11
>   PCI: setting IRQ 11 as level-triggered
>   ACPI: PCI Interrupt 0000:00:01.0[A] -> Link [LNKA] -> GSI 11 (level, low) -> IRQ 11
>   ...
>   ACPI: PCI Interrupt 0000:02:00.0[A] -> Link [LNKA] -> GSI 11 (level, low) -> IRQ 11
>   PCI: Setting latency timer of device 0000:02:00.0 to 64
>   sky2 v0.15 addr 0xbc000000 irq 11 Yukon-FE (0xb7) rev 1
> 
> (sky2 shares the interrupt with other devices, so we set IRQ 11
> to be level-triggered when we enable the interrupt for one of
> the other devices, so the "setting IRQ 11 as level-triggered"
> message is earlier than the sky2 driver init.)

-
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2006-06-05 19:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-01 21:04 Most interrupts are edge-triggered, non-APIC system Daniel Drake
2006-06-05 18:43 ` Bjorn Helgaas
2006-06-05 19:56   ` Daniel Drake [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-06-06  4:38 Brown, Len

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44848C5A.8090409@gentoo.org \
    --to=dsd@gentoo.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=joliveirinha@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=shemminger@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.