Re: 2.6.17-rc5-mm3

[Paul Fulghum <paulkf@microgate.com>]

Randy.Dunlap wrote:
> Those Kconfig + Makefiles are quite ugly to me.  I would rather see
> SYNCLINK depend on HDLC rather than using some tricks to SELECT HDLC.
> And then it selects HDLC (and HDLC depends on WAN), but (in my case)
> WAN was not enabled, and doing "SELECT HDLC" did not enable WAN.
> 
> Adding SELECT WAN and changing the hdlc (wan) Makefile to use
> obj-m or obj-y (it was ONLY obj-y for hdlc) fixes^W makes it build
> with no missing symbols.  However, I'll also see about a fix
> that uses "depends on HDLC" instead of "selects HDLC".

Generic HDLC support in the synclink drivers is optional.
Should the generic HDLC code be enabled even if it is not used?

Some of our customers would scream if we started forcing
them to compile and load unused code.

> Fix many missing hdlc_generic symbols when CONFIG_HDLC=m.
> When Selecting HDLC, also Select WAN.
> Fix Makefile to build for HDLC=y or HDLC=m.
> 
> +	select WAN if SYNCLINK_HDLC

If this is the accepted approach, then synclink_cs should be added also.
(drivers/char/pcmcia)

What about select WAN if HDLC instead?
Or does kbuild not propogate the reverse dependency?
(SYNCLINK_HDLC selects HDLC, HDLC selects WAN)

--
Paul